critical bug fix affecting AsyncActionNode

facontidavide · facontidavide · commit ca14aa865b00 · 2019-07-30T16:35:33.000+02:00
When a Tree is copied, all the thread related to AsyncActionNode where
invoked.
As a consequence, they are never executed, despite the fact that the
value RUNNING is returned.
diff --git a/src/action_node.cpp b/src/action_node.cpp
@@ -52,11 +52,9 @@ NodeStatus SimpleActionNode::tick()
 //-------------------------------------------------------
 
 AsyncActionNode::AsyncActionNode(const std::string& name, const NodeConfiguration& config)
-  : ActionNodeBase(name, config),
-  keep_thread_alive_(true),
-  start_action_(false)
+  : ActionNodeBase(name, config)
 {
-    thread_ = std::thread(&AsyncActionNode::asyncThreadLoop, this);
+
 }
 
 AsyncActionNode::~AsyncActionNode()
@@ -115,6 +113,10 @@ NodeStatus AsyncActionNode::executeTick()
     // The other thread is in charge for changing the status
     if (status() == NodeStatus::IDLE)
     {
+        if( thread_.joinable() == false) {
+            keep_thread_alive_ = true;
+            thread_ = std::thread(&AsyncActionNode::asyncThreadLoop, this);
+        }
         setStatus( NodeStatus::RUNNING );
         notifyStart();
     }

Original file line number	Diff line number	Diff line change
`@@ -52,11 +52,9 @@ NodeStatus SimpleActionNode::tick()`
`52`	`52`	`//-------------------------------------------------------`
`53`	`53`
`54`	`54`	`AsyncActionNode::AsyncActionNode(const std::string& name, const NodeConfiguration& config)`
`55`		`- : ActionNodeBase(name, config),`
`56`		`- keep_thread_alive_(true),`
`57`		`- start_action_(false)`
	`55`	`+ : ActionNodeBase(name, config)`
`58`	`56`	`{`
`59`		`- thread_ = std::thread(&AsyncActionNode::asyncThreadLoop, this);`
	`57`	`+`
`60`	`58`	`}`
`61`	`59`
`62`	`60`	`AsyncActionNode::~AsyncActionNode()`
`@@ -115,6 +113,10 @@ NodeStatus AsyncActionNode::executeTick()`
`115`	`113`	`// The other thread is in charge for changing the status`
`116`	`114`	`if (status() == NodeStatus::IDLE)`
`117`	`115`	`{`
	`116`	`+ if( thread_.joinable() == false) {`
	`117`	`+ keep_thread_alive_ = true;`
	`118`	`+ thread_ = std::thread(&AsyncActionNode::asyncThreadLoop, this);`
	`119`	`+ }`
`118`	`120`	`setStatus( NodeStatus::RUNNING );`
`119`	`121`	`notifyStart();`
`120`	`122`	`}`