ObjectControl not crashing if an object suddenly disconnect from server.#180
Merged
Conversation
LukasWikander
requested changes
Dec 3, 2019
LukasWikander
left a comment
Collaborator
There was a problem hiding this comment.
Discussed this in person. uiRecvMonitor causes the crash. Also, Jenkins complains 😢
…ol when checking current state.
Contributor
Author
|
Lukas, take a look at this again. |
LukasWikander
approved these changes
Dec 4, 2019
LukasWikander
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Two small changes, plus whatever Jenkins is complaining about (I'm guessing that you can just run formatSourceFiles.sh)
Contributor
Author
|
When an object suddenly disconnects from the server when ObjectControl is in state RUNNING, CONNECTED or ARMED it disconnects from all other objects and then goes to IDLE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not trying to do close(*socket) on the socket that has disconnected.