Feature default values before conf#239
Conversation
LukasWikander
left a comment
There was a problem hiding this comment.
I have suggested some changes, but I think there should be some use of the default parameter values in datadictionary as well since right now if something fails to find a parameter in the .conf file the result is undefined based on the initialization of GSD.
Co-Authored-By: LukasWikander <[email protected]>
Co-Authored-By: LukasWikander <[email protected]>
|
Guessing the formatting check doesn't pass, as I see no reason why this wouldn't compile. |
|
I have created a ticket for using these values in DataDictionary. |
Co-Authored-By: LukasWikander <[email protected]>
Co-Authored-By: LukasWikander <[email protected]>
|
"/opt/tomcat/.jenkins/workspace/tro_feature_defaultValuesBefConf/core/src/objectcontrol.c:194:25: error: ‘DEFAULT_ORIGO_HEADING’ undeclared (first use in this function) -- Jenkins, 2020 |
Forgot to change defines when your old suggestion was applied. Should build now.
Basically made all uninitialized paramaters use DEFAULT_DEFINES. Please discuss if these are accaptable or not.