Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Virtual virtual object#313

Merged
LukasWikander merged 12 commits into
devfrom
feature_virtualVirtualObject
Dec 11, 2020
Merged

Virtual virtual object#313
LukasWikander merged 12 commits into
devfrom
feature_virtualVirtualObject

Conversation

@LukasWikander

Copy link
Copy Markdown
Collaborator

My goal is to give us the ability to send exactly known MONR in our test scripts by expanding the tool we have.

@LukasWikander LukasWikander marked this pull request as ready for review December 7, 2020 11:02

@konglobemeralt konglobemeralt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice, this will really open up new avenues for testing. The only thing there is to complain about, which isn't really a part of what you have added right now, is the byte arrays created for other messages such as heab or headers. Right now when we have "message = bytearray.fromhex("7e7e0000020500090000009000050083c00d4a010000") " it makes it really hard to upade the script in case we change the messages or the header somewhat

@LukasWikander

Copy link
Copy Markdown
Collaborator Author

This looks really nice, this will really open up new avenues for testing. The only thing there is to complain about, which isn't really a part of what you have added right now, is the byte arrays created for other messages such as heab or headers. Right now when we have "message = bytearray.fromhex("7e7e0000020500090000009000050083c00d4a010000") " it makes it really hard to upade the script in case we change the messages or the header somewhat

Baby steps! We can add that as we start seeing the need.

@LukasWikander LukasWikander merged commit fc13776 into dev Dec 11, 2020
@LukasWikander LukasWikander deleted the feature_virtualVirtualObject branch December 11, 2020 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants