Feature osi connection#361
Merged
Merged
Conversation
Contributor
Author
|
There is a big change in the OSIEncoder that needs to be handled in this PR. |
Contributor
Author
|
Sending of OSI is now happening in ScenarioHandler::heartbeat(). Will also create a method for the construction of GlobalObjectGroundTruth_t and the other OSI related structs, at the momen is this also done in ScenarioHandler::heartbeat(). |
LukasWikander
requested changes
Jun 28, 2021
LukasWikander
left a comment
Collaborator
There was a problem hiding this comment.
This is what I could find from one sweep. Large PR:s are difficult to review and tend to (at least when I'm involved) get several review iterations as it's difficult to catch everything at once.
Also, what happens when an object is configured via injectorIDs but isn't OSI compatible?
… feature_OSIConnection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.