Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Feature edit workflow#5

Merged
viktorjo merged 5 commits into
devfrom
feature_edit_workflow
Nov 7, 2018
Merged

Feature edit workflow#5
viktorjo merged 5 commits into
devfrom
feature_edit_workflow

Conversation

@viktorjo

@viktorjo viktorjo commented Nov 6, 2018

Copy link
Copy Markdown
Contributor

Added picture to the git workflow. Perhaps there should be a more descriptive image text?

konglobemeralt and others added 5 commits October 30, 2018 12:34
Created document with example workflow, will continue editing and create a pull request for review before merging into master.
Co-Authored-By: konglobemeralt <[email protected]>

@konglobemeralt konglobemeralt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I think the image in combination with the text explains everything, but then again perhaps someone that has seen the document before would be the best judge ;)

@alfaro01 alfaro01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't seen the document before and I think it looks great. You get the jist of it from the picture and the text fills in all the gaps. But I think we should get an opinion from someone else aswell (Adam) because even though I haven't seen the document before, Jesper has described the process very well to me.

@viktorjo

viktorjo commented Nov 7, 2018

Copy link
Copy Markdown
Contributor Author

Good comments. I will ask both @sepast and @eriadam36 to look at this before I merge.

@eriadam36

Copy link
Copy Markdown
Contributor

I think it looks good. It gives a good explanation of how we are struckturing our work here on git and the method I belive is a good one plus I like that you have linked the extra material/sources for further studies.

@sepast

sepast commented Nov 7, 2018

Copy link
Copy Markdown
Contributor

Looks good. It seems to be a good workflow. I think we can make a fair judgement of the workflow after we have worked according to it for a while.

@sepast sepast self-requested a review November 7, 2018 12:22
@viktorjo viktorjo merged commit 958c3e5 into dev Nov 7, 2018
@viktorjo viktorjo deleted the feature_edit_workflow branch November 7, 2018 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants