rpcs3: Add --silent and --no-precompile flags for headless PKG installation#18713
Draft
Vishrut2403 wants to merge 1 commit into
Draft
rpcs3: Add --silent and --no-precompile flags for headless PKG installation#18713Vishrut2403 wants to merge 1 commit into
Vishrut2403 wants to merge 1 commit into
Conversation
Contributor
|
--no-precompile help text should note it only works with --silent, like --fullscreen does with --no-gui |
Contributor
Author
I'll look into making |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18616
Problem
The existing
--installpkgflag opens the PKG installation dialog and requires a manual click to proceed, making scripted installs impossible.Changes
--silentbypasses the dialog and installs with the same defaults as the dialog. Precompile caches enabled, no shortcuts created.--no-precompilecan be combined with it to skip cache precompilation after install.Also added null checks for
m_game_list_frameinHandlePackageInstallationsince it's null in CLI mode and would crash after installation otherwise.Testing
Tested with a PS3 update PKG (God of War III, BCUS98111):
No dialog appeared. Normal
--installpkgbehavior is unchanged.