overlays: Add Skylander Portal Overlay#18767
Draft
deReeperJosh wants to merge 10 commits into
Draft
Conversation
Megamouse
reviewed
May 19, 2026
Contributor
|
UI critiques:
These may seem nitpicky but they need to be fixed now because nobody is going to go back and work on this later. |
Contributor
Author
|
Have slightly tidied up the UI based on the above comments, I don't think the UI will change at all, the list view of each "slot" is how it is best to Load/Clear/Create IMO Padding has been added to the file/folder icons: 
Image buttons have been moved to the bottom of the Dialog: 
And the Item in the menu will only display if the portal is activated now |
Megamouse
reviewed
May 20, 2026
Contributor
|
Both error paths now clean, Nice work |
Contributor
|
Cause of windows build failure as per github CI logs is usb_device.h including libusb before windows.h and libusb's SSIZE_T typedef conflicts with the newer windows sdk. Maybe moving #include <windows.h> above #include <libusb.h> in usb_device.h should fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial development work for #17093
Adds in a new Menu to settings in the overlay to control the Skylander Portal, currently works with clearing and loading with a more complex create skylander user interface required (PR marked as draft until this is complete)
This will be my first contribution to the overlays section, so any feedback/reviews welcome.
New Menu item in the overlay appears above Trophies:
I would like to only conditionally display this (so the menu doesn't get crowded) if the game that is being run is one of the Skylanders/Disney Infinity/Lego Dimensions/Kamen Rider Summonride games, if anyone knows how I could achieve this that would be appreciated.
Tried to make the UI as similar to the Qt Dialog, with a list view and 3 possible button interactions to clear, load and create (create in progress)
When Loading, opens up a simple file selector dialog, where only folders and appropriate file types are displayed, and folders can be navigated through:
As there is also a Qt Dialog, I wanted to make sure that both views shared the same Skylander information, so a few shared methods have been moved to the Skylander.h header file.