Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Do we want to split resampleParams into two parameters? #69

@alexhroom

Description

@alexhroom

Currently resampleParams is a two item list (default [0.7, 50]), representing a minimum angle (in units 1/pi) and number of points used in resampling. This is very unintuitive and difficult for the user to tell what these parameters represent. If we split them into two parameters, named e.g. resampleMinAngle and resampleNPoints, then we get the following benefits:

  • easier to document and understand what these parameters are from a user point-of-view
  • easier to input in both GUI (min angle can be a float spinbox and npoints an int) and in scripts
  • easier to validate (in Python, can let Pydantic handle it entirely and also add handling to ensure n-points is an int)
  • do not have to write specialised GUI code just to handle a 2-item list once in the Controls tab

Please comment any thoughts, problems, or alternatives?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions