Thanks to visit codestin.com
Credit goes to github.com

Skip to content

regression: Upload quality is too low #6318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 28, 2025
Merged

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Apr 24, 2025

Proposed changes

Regression introduced on #6143
The idea there was to remove compression, but I read Expo docs incorrectly. Instead of checking SDK 50 (our current version), I read SDK 52, which contains a breaking change switching the default quality from 0.2 to 1.0.

That made me think the default was enough, but it actually ended up always compressing with 0.2.

This PR sets it to 0.8, which is the default for react-native-crop-picker, the lib we were using before this whole lib migration https://github.com/ivpusic/react-native-image-crop-picker?tab=readme-ov-file#request-object
Hopefully that's enough, but we can play with the value in the future.
Also note that we want to introduce #6321 soon, so we might deliver a quality toggle so the user will be able to choose between SD and HD quality before uploading.

Issue(s)

NATIVE-851

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello force-pushed the regression.compress-media branch from 1c9127d to d49aeb4 Compare April 24, 2025 17:45
@diegolmello diegolmello marked this pull request as ready for review April 24, 2025 18:17
@diegolmello diegolmello changed the title feat: compress media regression: compress media Apr 28, 2025
Copy link
Contributor

@OtavioStasiak OtavioStasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
tested on iPhone 13 (18.3.2)

@diegolmello diegolmello changed the title regression: compress media regression: Upload quality is too low Apr 28, 2025
@diegolmello diegolmello merged commit 3095fcd into develop Apr 28, 2025
5 of 10 checks passed
@diegolmello diegolmello deleted the regression.compress-media branch April 28, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants