Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(Android): Enable edge-to-edge #6380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 243 commits into from
Jul 2, 2025
Merged

feat(Android): Enable edge-to-edge #6380

merged 243 commits into from
Jul 2, 2025

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented May 23, 2025 •
edited by jira bot
Loading

Proposed changes

  • Enables edge-to-edge on Android
  • Removes react-native-ui-lib
  • Removes react-native-navigation-bar-color
  • Removes rn-root-view
  • Removes @codler/react-native-keyboard-aware-scroll-view
  • Adds expo-navigation-bar
  • Adds expo-status-bar
  • Adds expo-system-ui
  • Adds react-native-keyboard-controller
  • Refactored emoji picker to use react-native-reanimated instead of tracking view libs from react-native-ui-lib

Issue(s)

Closes #6223
NATIVE-873

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello
kinda building iOS
c5deaff
@diegolmello
temp fix header buttons
32fd371
@diegolmello
Merge branch 'develop' into upgrade-rn
2fc977d
@diegolmello
pods
2a2209c
@diegolmello
Android is kinda building
7c29a0e
@diegolmello
Patch software-mansion/react-native-screens#2219
f90e17b
@diegolmello
iOS building once again
b60d10d
@diegolmello
Revert "Patch software-mansion/react-native-screens#2219"
43f48bd 
This reverts commit f90e17b.
@diegolmello
Fix pods on old arch
8a75e26
@diegolmello
Cleanup podfile
7089a18
@diegolmello
Temp fix lint/ts
843a254
@diegolmello
temp remove unit tests on ci
b75ca3f
@diegolmello
pod old arch on CI
ae3d775
@diegolmello
Added firebase
40643e4
@diegolmello
Bitcode is still an issue. Fixed on Podfile again.
6fb30fe
@diegolmello
Remove Reactotron
f578509
@diegolmello
BackHandler fixes
4d3a494
@diegolmello
Fix Android source maps upload
2ea91f6
@diegolmello
Fix push on Android
624ab33
@diegolmello
Fix lint
f4ccf38
@diegolmello
Expo-asset is required for videoconf
d412811
@diegolmello
Update testing setup and dependencies: mock expo-font in jest setup, …
94c88d6 
…upgrade @testing-library/react-native to 13.2.0, and update jest-expo to 52.0.6. Refactor useEndpointData tests to use render from @testing-library/react-native.
@diegolmello
chore: update Babel configuration to use babel-preset-expo
4e9e564
@diegolmello
test: refactor MessageComposer tests
70f320a
@diegolmello
test: update ReactionsList and useEndpointData tests
e84cca2
@diegolmello
test: enable testing in CircleCI configuration
d91bf43
@diegolmello
https://reactnative.dev/blog/2025/01/21/version-0.77#rctappdependency…
0bec09f 
…provider
@diegolmello
Fix lint and pods
3b8c9c5
@diegolmello
chore: update detox dependency
916ce2a
@diegolmello
Remove bottom sheet patch
4cca385
OtavioStasiak
OtavioStasiak requested changes Jun 13, 2025
View reviewed changes
Copy link
Contributor

@OtavioStasiak OtavioStasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On iOS, everything works as expected. On Android (landscape), the emoji search bar doesn’t appear.
Screenshot_20250613-140537

OtavioStasiak
OtavioStasiak approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@OtavioStasiak OtavioStasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!
Just fix the failing tests and you’re good to merge.

@diegolmello diegolmello mentioned this pull request Jun 18, 2025
Open
@diegolmello diegolmello force-pushed the chore.keyboard-controller branch from 17d1f7b to 1991422 Compare June 25, 2025 18:50
@diegolmello diegolmello mentioned this pull request Jun 26, 2025
Merged
10 tasks
OtavioStasiak
OtavioStasiak approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@OtavioStasiak OtavioStasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@diegolmello diegolmello merged commit 258c8a4 into develop Jul 2, 2025
5 of 7 checks passed
@diegolmello diegolmello deleted the chore.keyboard-controller branch July 2, 2025 19:38
@OtavioStasiak OtavioStasiak mentioned this pull request Jul 4, 2025
Merged
10 tasks
@diegolmello diegolmello mentioned this pull request Jul 15, 2025
Draft
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OtavioStasiak OtavioStasiak OtavioStasiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: Remove react-native-ui-lib
2 participants
@diegolmello @OtavioStasiak