Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: remove spaces from allowList to ensure correct MIME type validation #6490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Jul 11, 2025

Proposed changes

This PR ensures that file uploads are not blocked due to spaces in the allowList string.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-941

How to test or reproduce

  • on workspace settings go to File Upload > Allowed File Types and add the allowed list below:
application/msword, application/vnd.openxmlformats-officedocument.wordprocessingml.document, application/vnd.ms-excel, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet, application/vnd.ms-powerpoint, application/vnd.openxmlformats-officedocument.presentationml.presentation, application/vnd.oasis.opendocument.text, application/pdf, image/jpeg, image/png, text/plain, image/gif, image/heif, image/*, image/heic, image/pjpeg, image/x-png
  • Open the app;
  • Go to room;
  • Try to take a photo and send on iOS;

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak changed the title fix: sanitize empty spaces fix: prevent app break when allowList has space after comma Jul 11, 2025
@OtavioStasiak OtavioStasiak changed the title fix: prevent app break when allowList has space after comma fix: prevent block file upload when allowList has space after comma Jul 11, 2025
@OtavioStasiak OtavioStasiak changed the title fix: prevent block file upload when allowList has space after comma fix: remove spaces from allowList to ensure correct MIME type validation Jul 11, 2025
@OtavioStasiak OtavioStasiak marked this pull request as ready for review July 11, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants