-
-
Notifications
You must be signed in to change notification settings - Fork 207
Open
Description
Title: Documentation Issues: Atmospheric Model, Colab Links, CSV Thrust Curves, Parachute Triggers, Flight Variables, and Dependency Notes
Environment:
- Python 3.14.0, RocketPy 1.10.0, macOS
- Jupyter Notebook in
venv(~/RocketPy/rocketpy/venv)
Issue:
- Invalid Atmospheric Model: Tutorial uses
env.set_atmospheric_model(type="Standard"), causingValueError: Unknown model type 'standard'. Correct type isstandard_atmosphere(lowercase). - Colab Notebook Link Error: Docs link to
.html(e.g., https://colab.research.google.com/github/RocketPy-Team/rocketpy/blob/master/docs/notebooks/environment/environment_class_usage.html) fails with "Could not find environment_class_usage.html". Correct is.ipynb. - 404 Error: Tutorial implies
keron_thrust_curve.csvat../data/motors/projeto-jupiter/, butmainbranch URLs yield "404: Not Found". Correct branch ismaster. - Impulse Mismatch: Tutorial expects ~1403 Ns.
keron_thrust_curve.csvyields 1403.183 Ns (max 1068.36 N at 1.508 s, spiky).mandioca_thrust_curve.csvyields 7568.587 Ns (max 2606 N at 3.258 s, smoother). - Duplicate Files: Initially,
keronandmandiocaCSVs were identical (4689 bytes). Fixed by redownloadingkeron(2849 bytes, e.g.,0,3.8). - Parachute Warnings:
keronsimulation had warnings: "Trying to add flight phase starting together/after the one proceeding it" due tomain(800 m) anddrogue(apogee) triggering at 8.419 s. Fixed withmaintrigger at 600 m. - Invalid Flight Variable:
Flight.export_datawithvertical_velocitycausesAttributeError: Variable 'vertical_velocity' not found in Flight class. Correct variable isvz. - Missing Dependency:
pandasnot included in RocketPy’s default dependencies, causingModuleNotFoundError. Fixed by installingjupyterandpandasinvenv. - Export Column Error:
Flight.export_dataCSV uses# Time (s)(nottime) and adds spaces in column names (e.g.,Vz (m/s)), causingKeyError. Using CSV column names (e.g.,Altitude AGL (m)) inexport_datacausesAttributeError; needsaltitude,speed,vz.Flight.export_datadeprecated; useFlightDataExporter. - FlightDataExporter Error:
FlightDataExporter.export_data()raisedTypeErrorwithvariables=["altitude", "speed", "vz"]; fixed withaltitude,speed,vzas positional arguments. CSV uses# Time (s)(notTime), causingKeyError.
Steps to Reproduce:
- Ran simulation with
type="Standard":ValueError. Fixed withtype="standard_atmosphere". - Tried Colab link: "Could not find environment_class_usage.html".
- Ran
curlwithmain: "404: Not Found". - API check (
curl https://api.github.com/repos/RocketPy-Team/RocketPy/contents/data/motors/projeto-jupiter?ref=master): Confirmed files inmaster. - Downloaded CSVs: Initially identical. Redownloaded
keron: Distinct data. - Ran
SolidMotor:keron1403.183 Ns (spiky);mandioca7568.587 Ns (smooth). - Ran
keronsimulation: Parachute warnings. Fixed withmaintrigger at 600 m. - Ran
mandiocasimulation: 4310.649 m AGL apogee, 368.021 m/s max speed, stable 2.194-3.844 c, no warnings. - Ran
export_datawithvertical_velocity:AttributeError. Fixed withvz. - Ran CSV read with
pandas:ModuleNotFoundError. Fixed withpip install jupyter pandasinvenv. - Ran
export_dataand filtered CSV withdf['time']:KeyError. Fixed withdf['# Time (s)']. - Ran
export_datawithAltitude AGL (m):AttributeError. Fixed withaltitude. - Plotted CSV with
df['Vz (m/s)']:KeyError. Fixed withdf[' Vz (m/s)']. - Ran
FlightDataExporterwithvariables=["altitude", "speed", "vz"]:TypeError. Fixed withaltitude,speed,vz. - Ran
FlightDataExporterand filtered withdf['Time']:KeyError. Fixed withdf['# Time (s)'].
Expected:
- Docs use
standard_atmosphere. - Colab links to
.ipynb. masterURLs.- CSVs distinct; impulse matches.
- Parachutes trigger sequentially.
Flight.export_datausesvz.pandasandjupyterinvenv.- CSV has
# Time (s),Vz (m/s);FlightDataExporterworks with positional arguments.
Actual:
Standardinvalid; needsstandard_atmosphere..htmllinks fail.main404s.- CSVs initially identical.
mandiocaimpulse 7568.587 Ns.- Parachute warnings at 800 m.
vertical_velocityinvalid; needsvz.pandasmissing until installed invenv.- CSV uses
# Time (s),Vz (m/s);Altitude AGL (m)invalid inexport_data. FlightDataExporterfails withvariableslist; uses# Time (s).
Suggested Fix:
- Change "Standard" to
standard_atmosphere. - Update Colab links to
.ipynb. - Use
masterURLs. - Ensure
keronandmandiocaCSVs differ. - Update impulse for
mandioca. - Set
mainparachute trigger to 600 m. - Update
Flight.export_datadocs to listvz. - Note
pandasandjupyteras dependencies invenv. - Clarify CSV column names (
# Time (s),Vz (m/s)vs.Time,Vz). - Update tutorial to use
FlightDataExporterwithaltitude,speed,vzand filter with# Time (s). - Recommend
FlightDataExporteroverFlight.export_data.
Additional Notes:
- Workaround: Local Jupyter with
standard_atmosphere; redownload CSVs withmaster; usevz; installjupyterandpandasinvenv; useFlightDataExporterwithaltitude,speed,vz; filter withdf['# Time (s)']; plot withdf[' Vz (m/s)']. keron(1403 Ns, spiky) suits heavy payloads in lower LEO;mandioca(7568 Ns, smooth, 4310.649 m AGL apogee, -5.457 m/s impact) suits high-altitude, light payloads.- Debugging at odd hours feels like a lunar mission! Happy to test or share plots.
Gui-FernandesBR
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Backlog