Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(modes): custom modes under custom path not showing #8499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrubens merged 1 commit into from
Oct 28, 2025
Merged

fix(modes): custom modes under custom path not showing #8499

mrubens merged 1 commit into from
Oct 28, 2025

Conversation

@elianiva
Copy link
Contributor

@elianiva elianiva commented Oct 4, 2025 •
edited by ellipsis-dev bot
Loading

Related GitHub Issue

Closes: #8122

Roo Code Task Context (Optional)

Description

Upon setting custom storage path, custom modes didn't show up. This PR fixes it by replacing hardcoded global storage path to the one set by the user.

Test Procedure

  1. Set custom global storage path
  2. Create a new mode
  3. Restart, it should still show the custom modes we've defined earlier in the custom directory.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch

@elianiva

Important

Fixes issue with custom modes not showing by using user-defined storage path instead of hardcoded path.

  • Behavior:
    • Replaces hardcoded global storage path with user-defined path in createModeInstructions() in create-mode.ts and getModesSection() in modes.ts.
    • Ensures settings directory is created using ensureSettingsDirectoryExists() in modes.ts.
  • Utilities:
    • Updates ensureSettingsDirectoryExists() in globalContext.ts to use getSettingsDirectoryPath() for custom path handling.
    • Modifies migrateSettings() in migrateSettings.ts to use getSettingsDirectoryPath() for determining settings directory.

This description was created by Ellipsis for 9e93dd8. You can customize this summary. It will automatically update as commits are pushed.

@elianiva elianiva requested review from cte, jr and mrubens as code owners October 4, 2025 05:36
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Oct 4, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Oct 4, 2025
roomote[bot]
roomote bot reviewed Oct 4, 2025
View reviewed changes
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a couple of small follow-ups to improve correctness and maintainability.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 28, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Oct 28, 2025
@hannesrudolph hannesrudolph added PR - Needs Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Oct 28, 2025
@mrubens mrubens merged commit 06af804 into RooCodeInc:main Oct 28, 2025
26 checks passed
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Oct 28, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roomote roomote[bot] roomote[bot] left review comments

@mrubens mrubens mrubens approved these changes

@daniel-lxs daniel-lxs daniel-lxs approved these changes

@cte cte Awaiting requested review from cte cte is a code owner

@jr jr Awaiting requested review from jr jr is a code owner

Assignees

No one assigned

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer PR - Needs Review size:S This PR changes 10-29 lines, ignoring generated files.

Projects

No open projects
Roo Code Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Custom storage path not used for custom modes (global YAML ignored)

4 participants

@elianiva @mrubens @daniel-lxs @hannesrudolph