fix(editor): prevent file editing issues when git diff views are open#8676
Merged
mrubens merged 3 commits intoRooCodeInc:mainfrom Oct 16, 2025
Merged
fix(editor): prevent file editing issues when git diff views are open#8676mrubens merged 3 commits intoRooCodeInc:mainfrom
mrubens merged 3 commits intoRooCodeInc:mainfrom
Conversation
Add scheme checks to ensure only file:// URIs are matched when finding editors, avoiding issues with git diffs and other schemes. Includes error logging for failed editor lookups.
daniel-lxs
approved these changes
Oct 16, 2025
mrubens
approved these changes
Oct 16, 2025
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add scheme checks to ensure only file:// URIs are matched when finding editors, avoiding issues with git diffs and other schemes. Includes error logging for failed editor lookups.
Before: Roo edits the diff view and does not touch the file
After: Roo edits the actual file, not the diff
Important
Add scheme checks in
DiffViewProviderto match onlyfile://URIs, preventing git diff issues, and update tests accordingly.DiffViewProviderto match onlyfile://URIs, preventing issues with git diffs.DiffViewProvider.DiffViewProvider.spec.tsto includescheme: "file"in mock editor URIs.file://URIs.This description was created by
for 6cec1f3. You can customize this summary. It will automatically update as commits are pushed.