Add timeout to OpenAI Compatible Provider Client#9898
Merged
Conversation
Contributor
Review complete. The changes since the last review have been verified and all tests pass. Summary:
No issues found. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
6b77a9a to
49a7ae1
Compare
hannesrudolph
approved these changes
Dec 9, 2025
Collaborator
hannesrudolph
left a comment
There was a problem hiding this comment.
Approved: timeout is now passed to OpenAI-compatible client using validated config; tests cover default/custom/zero values.
mrubens
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #
Description
Adds a timeout to the OpenAI Compatable Provider Client. This instructs the client to wait for the configured amount of timeout before giving up on the xhr request and marking it as an error.
Test Procedure
Run Added test.
Manual testing can be done by using the provider with the cloud service and monitoring for timeout failures. The Client should recover more quickly and continue on with the agentic loop when a timeout occurs.
Pre-Submission Checklist
Documentation Updates
Important
Adds a configurable timeout to the OpenAI Compatible Provider Client, with tests to ensure correct behavior.
base-openai-compatible-provider.tsusinggetApiRequestTimeout().base-openai-compatible-provider-timeout.spec.tsto verify timeout behavior.getApiRequestTimeoutinbase-openai-compatible-provider-timeout.spec.tsto simulate different timeout scenarios.This description was created by
for 49a7ae1. You can customize this summary. It will automatically update as commits are pushed.