Generalise how package version isn't stabilized for dev/preview stages

RussKie · RussKie · commit 68d983e4577b · 2024-11-14T13:37:49.000+11:00
Follow up on dotnet#5632
diff --git a/eng/MSBuild/ProjectStaging.targets b/eng/MSBuild/ProjectStaging.targets
@@ -28,4 +28,10 @@
     <Description Condition="'$(Stage)' == 'obsolete'">Obsolete Package. $(Description)</Description>
   </PropertyGroup>
 
+  <PropertyGroup>
+    <SuppressFinalPackageVersion>false</SuppressFinalPackageVersion>
+    <!-- Makes it such that the package version won't be stabilized even when the rest of the repo is going stable. -->
+    <SuppressFinalPackageVersion Condition="'$(Stage)' == 'dev' or '$(Stage)' == 'preview'">true</SuppressFinalPackageVersion>
+  </PropertyGroup>
+
 </Project>
diff --git a/src/Generators/Microsoft.Gen.MetricsReports/Directory.Build.props b/src/Generators/Microsoft.Gen.MetricsReports/Directory.Build.props
@@ -4,7 +4,6 @@
   the project itself. -->
   <PropertyGroup>
     <Stage>dev</Stage>
-    <SuppressFinalPackageVersion>true</SuppressFinalPackageVersion>
   </PropertyGroup>
   <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" />
 </Project>
diff --git a/src/Libraries/Microsoft.Extensions.AI.Abstractions/Microsoft.Extensions.AI.Abstractions.csproj b/src/Libraries/Microsoft.Extensions.AI.Abstractions/Microsoft.Extensions.AI.Abstractions.csproj
@@ -8,7 +8,6 @@
 
   <PropertyGroup>
     <Stage>preview</Stage>
-    <SuppressFinalPackageVersion>true</SuppressFinalPackageVersion>
     <MinCodeCoverage>0</MinCodeCoverage>
     <MinMutationScore>0</MinMutationScore>
   </PropertyGroup>
diff --git a/src/Libraries/Microsoft.Extensions.AI.AzureAIInference/Microsoft.Extensions.AI.AzureAIInference.csproj b/src/Libraries/Microsoft.Extensions.AI.AzureAIInference/Microsoft.Extensions.AI.AzureAIInference.csproj
@@ -8,7 +8,6 @@
 
   <PropertyGroup>
     <Stage>preview</Stage>
-    <SuppressFinalPackageVersion>true</SuppressFinalPackageVersion>
     <MinCodeCoverage>0</MinCodeCoverage>
     <MinMutationScore>0</MinMutationScore>
   </PropertyGroup>
diff --git a/src/Libraries/Microsoft.Extensions.AI.Ollama/Microsoft.Extensions.AI.Ollama.csproj b/src/Libraries/Microsoft.Extensions.AI.Ollama/Microsoft.Extensions.AI.Ollama.csproj
@@ -8,7 +8,6 @@
 
   <PropertyGroup>
     <Stage>preview</Stage>
-    <SuppressFinalPackageVersion>true</SuppressFinalPackageVersion>
     <MinCodeCoverage>0</MinCodeCoverage>
     <MinMutationScore>0</MinMutationScore>
   </PropertyGroup>
diff --git a/src/Libraries/Microsoft.Extensions.AI.OpenAI/Microsoft.Extensions.AI.OpenAI.csproj b/src/Libraries/Microsoft.Extensions.AI.OpenAI/Microsoft.Extensions.AI.OpenAI.csproj
@@ -8,7 +8,6 @@
 
   <PropertyGroup>
     <Stage>preview</Stage>
-    <SuppressFinalPackageVersion>true</SuppressFinalPackageVersion>
     <MinCodeCoverage>0</MinCodeCoverage>
     <MinMutationScore>0</MinMutationScore>
   </PropertyGroup>
diff --git a/src/Libraries/Microsoft.Extensions.AI/Microsoft.Extensions.AI.csproj b/src/Libraries/Microsoft.Extensions.AI/Microsoft.Extensions.AI.csproj
@@ -10,7 +10,6 @@
 
   <PropertyGroup>
     <Stage>preview</Stage>
-    <SuppressFinalPackageVersion>true</SuppressFinalPackageVersion>
     <MinCodeCoverage>0</MinCodeCoverage>
     <MinMutationScore>0</MinMutationScore>
   </PropertyGroup>
diff --git a/src/Libraries/Microsoft.Extensions.Diagnostics.Probes/Directory.Build.props b/src/Libraries/Microsoft.Extensions.Diagnostics.Probes/Directory.Build.props
@@ -3,7 +3,6 @@
   importing the root level Directory.Build.props file. This property should be kept in here, as opposed to moving it to
   the project itself. -->
   <PropertyGroup>
-    <SuppressFinalPackageVersion>true</SuppressFinalPackageVersion>
     <Stage>dev</Stage>
     <StageDevDiagnosticId>EXTEXP0015</StageDevDiagnosticId>
   </PropertyGroup>
diff --git a/src/Libraries/Microsoft.Extensions.Hosting.Testing/Directory.Build.props b/src/Libraries/Microsoft.Extensions.Hosting.Testing/Directory.Build.props
@@ -3,7 +3,6 @@
   importing the root level Directory.Build.props file. This property should be kept in here, as opposed to moving it to
   the project itself. -->
   <PropertyGroup>
-    <SuppressFinalPackageVersion>true</SuppressFinalPackageVersion>
     <Stage>dev</Stage>
     <StageDevDiagnosticId>EXTEXP0016</StageDevDiagnosticId>
   </PropertyGroup>
diff --git a/src/Libraries/Microsoft.Extensions.Options.Contextual/Directory.Build.props b/src/Libraries/Microsoft.Extensions.Options.Contextual/Directory.Build.props
@@ -3,7 +3,6 @@
   importing the root level Directory.Build.props file. This property should be kept in here, as opposed to moving it to
   the project itself. -->
   <PropertyGroup>
-    <SuppressFinalPackageVersion>true</SuppressFinalPackageVersion>
     <Stage>dev</Stage>
     <StageDevDiagnosticId>EXTEXP0017</StageDevDiagnosticId>
   </PropertyGroup>
