Fix bz2 pickle (#5819)

youknowone · web-flow · commit b1ecdf38b80b · 2025-06-23T08:55:59.000+09:00
diff --git a/Lib/test/test_bz2.py b/Lib/test/test_bz2.py
@@ -676,8 +676,6 @@ def testCompress4G(self, size):
         finally:
             data = None
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def testPickle(self):
         for proto in range(pickle.HIGHEST_PROTOCOL + 1):
             with self.assertRaises(TypeError):
@@ -736,8 +734,6 @@ def testDecompress4G(self, size):
             compressed = None
             decompressed = None
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def testPickle(self):
         for proto in range(pickle.HIGHEST_PROTOCOL + 1):
             with self.assertRaises(TypeError):
diff --git a/stdlib/src/bz2.rs b/stdlib/src/bz2.rs
@@ -103,6 +103,11 @@ mod _bz2 {
             self.state.lock().needs_input()
         }
 
+        #[pymethod(name = "__reduce__")]
+        fn reduce(&self, vm: &VirtualMachine) -> PyResult<()> {
+            Err(vm.new_type_error("cannot pickle '_bz2.BZ2Decompressor' object".to_owned()))
+        }
+
         // TODO: mro()?
     }
 
@@ -185,5 +190,10 @@ mod _bz2 {
             state.flushed = true;
             Ok(vm.ctx.new_bytes(out.to_vec()))
         }
+
+        #[pymethod(name = "__reduce__")]
+        fn reduce(&self, vm: &VirtualMachine) -> PyResult<()> {
+            Err(vm.new_type_error("cannot pickle '_bz2.BZ2Compressor' object".to_owned()))
+        }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -103,6 +103,11 @@ mod _bz2 {`
`103`	`103`	`self.state.lock().needs_input()`
`104`	`104`	`}`
`105`	`105`
	`106`	`+ #[pymethod(name = "__reduce__")]`
	`107`	`+ fn reduce(&self, vm: &VirtualMachine) -> PyResult<()> {`
	`108`	`+ Err(vm.new_type_error("cannot pickle '_bz2.BZ2Decompressor' object".to_owned()))`
	`109`	`+ }`
	`110`	`+`
`106`	`111`	`// TODO: mro()?`
`107`	`112`	`}`
`108`	`113`
`@@ -185,5 +190,10 @@ mod _bz2 {`
`185`	`190`	`state.flushed = true;`
`186`	`191`	`Ok(vm.ctx.new_bytes(out.to_vec()))`
`187`	`192`	`}`
	`193`	`+`
	`194`	`+ #[pymethod(name = "__reduce__")]`
	`195`	`+ fn reduce(&self, vm: &VirtualMachine) -> PyResult<()> {`
	`196`	`+ Err(vm.new_type_error("cannot pickle '_bz2.BZ2Compressor' object".to_owned()))`
	`197`	`+ }`
`188`	`198`	`}`
`189`	`199`	`}`