Thanks to visit codestin.com
Credit goes to github.com

Skip to content

"Delete unused variables" doesn't work if a method is named like the variable #222

@ConjuringCoffee

Description

@ConjuringCoffee

Hi Jörg-Michael, I found an issue with the rule "Delete unused variables".

Here's a scenario in which it works correctly.

Before:

REPORT yexample.
CLASS lcl_ DEFINITION CREATE PRIVATE.

  PUBLIC SECTION.
    METHODS test1.

ENDCLASS.


CLASS lcl_ IMPLEMENTATION.
  METHOD test1.
    SELECT
      FROM e071
      FIELDS activity
      INTO TABLE @DATA(test).

    test1( ).
  ENDMETHOD.
ENDCLASS.

After:

REPORT yexample.
CLASS lcl_ DEFINITION CREATE PRIVATE.

  PUBLIC SECTION.
    METHODS test1.
ENDCLASS.


CLASS lcl_ IMPLEMENTATION.
  METHOD test1.
    SELECT
      FROM e071
      FIELDS activity
      " TODO: variable is assigned but never used (ABAP cleaner)
      INTO TABLE @DATA(test).

    test1( ).
  ENDMETHOD.
ENDCLASS.

It doesn't work if the method is named like the variable. This code is unchanged:

REPORT yexample.
CLASS lcl_ DEFINITION CREATE PRIVATE.

  PUBLIC SECTION.
    METHODS test.
ENDCLASS.


CLASS lcl_ IMPLEMENTATION.
  METHOD test.
    SELECT
      FROM e071
      FIELDS activity
      INTO TABLE @DATA(test).

    test( ).
  ENDMETHOD.
ENDCLASS.

Thanks! 🙂

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions