Fix issue with finding dependency exceptions in ast.AsyncFunctionDef endpoints

Saran33 · Saran33 · commit e345ba6decec · 2023-04-02T21:13:06.000+01:00
diff --git a/fastapi_docx/exception_finder.py b/fastapi_docx/exception_finder.py
@@ -209,7 +209,7 @@ def find_dependency_exceptions(
         source = inspect.getsource(func)
         tree = ast.parse(source)
 
-        for node in find_nodes(tree, ast.FunctionDef):
+        for node in find_nodes(tree, (ast.FunctionDef, ast.AsyncFunctionDef)):
             for kwarg in chain(node.args.defaults, node.args.kw_defaults):
                 if (
                     kwarg
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "fastapi-docx"
-version = "0.1.7"
+version = "0.1.8"
 description = "Extend a FastAPI OpenAPI spec to include all possible HTTPException or custom Exception response schemas."
 authors = ["Saran Connolly <saran@example.com>"]
 readme = "README.md"
diff --git a/tests/unit_tests/fixtures/dependencies.py b/tests/unit_tests/fixtures/dependencies.py
@@ -15,6 +15,11 @@ def __init__(self):
         self.bind = None
 
 
+class User:
+    def __init__(self, id: int = 1):
+        self.id = id
+
+
 class DbDeps(AppDeps):
     @staticmethod
     def get_db() -> Generator:
@@ -50,6 +55,21 @@ def get_current_user() -> dict[str, Any]:
             raise TooManyRequests(context=user)
         return user
 
+    @staticmethod
+    async def get_current_user_obj() -> User:
+        try:
+            user = User()
+        except Exception:
+            raise HTTPException(
+                status_code=status.HTTP_403_FORBIDDEN,
+                detail="Could not validate credentials",
+            )
+        if not user:
+            raise HTTPException(status_code=404, detail="User not found")
+        if user["name"] == "bot":
+            raise TooManyRequests(context=user)
+        return user
+
     @staticmethod
     def require_auth() -> dict[str, Any]:
         try:
diff --git a/tests/unit_tests/test_dependency_exceptions.py b/tests/unit_tests/test_dependency_exceptions.py
@@ -1,25 +1,31 @@
+from typing import Any
+
 from fastapi import APIRouter, Depends, FastAPI
 
 from tests.unit_tests.fixtures.custom_exceptions import (
     AppExceptionCase,
     AppExecptionSchema,
     app_exception_handler,
 )
-from tests.unit_tests.fixtures.dependencies import AppDeps, CallableDep, UserDeps
+from tests.unit_tests.fixtures.dependencies import AppDeps, CallableDep, User, UserDeps
 from tests.unit_tests.fixtures.services import AppService, UserService
 from tests.unit_tests.setup import OpenApiTest
 
 router = APIRouter()
 
 
 @router.get("/me")
-def get_user(*, user_in, current_user=Depends(UserDeps.get_current_user)):
+def get_user(
+    *, user_in, current_user: dict[str, Any] = Depends(UserDeps.get_current_user)
+):
     result = UserService.get_authenticated(user_in)
     return result
 
 
 @router.put("/me")
-def update_user(user_in, current_user=Depends(UserDeps.get_current_user)):
+async def update_user(
+    user_in, current_user: User = Depends(UserDeps.get_current_user_obj)
+):
     result = UserService.get_authenticated(user_in)
     return result
 
