bug symfony#46769 [HttpKernel] Fix a PHP 8.1 deprecation notice in HttpCache (mpdude)

nicolas-grekas · nicolas-grekas · commit 45db39c0d3f7 · 2022-06-26T18:26:34.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [HttpKernel] Fix a PHP 8.1 deprecation notice in HttpCache | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | PHP 8.1 may trigger a deprecation notice `PHP Deprecated: abs(): Passing null to parameter #1 ($num) of type int|float is deprecated in .../symfony/http-kernel/HttpCache/HttpCache.php on line 721` The reason is that `$entry->getTtl()` may return `null` for cache entries where no freshness information is present. I think we would err on the safe side by not using stale-while-revalidate behaviour in this case. Commits ------- d0955c2 [HttpKernel] Fix a PHP 8.1 deprecation notice in HttpCache
diff --git a/src/Symfony/Component/HttpKernel/HttpCache/HttpCache.php b/src/Symfony/Component/HttpKernel/HttpCache/HttpCache.php
@@ -718,7 +718,7 @@ private function mayServeStaleWhileRevalidate(Response $entry): bool
             $timeout = $this->options['stale_while_revalidate'];
         }
 
-        return abs($entry->getTtl()) < $timeout;
+        return abs($entry->getTtl() ?? 0) < $timeout;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -718,7 +718,7 @@ private function mayServeStaleWhileRevalidate(Response $entry): bool`
`718`	`718`	`$timeout = $this->options['stale_while_revalidate'];`
`719`	`719`	`}`
`720`	`720`
`721`		`- return abs($entry->getTtl()) < $timeout;`
	`721`	`+ return abs($entry->getTtl() ?? 0) < $timeout;`
`722`	`722`	`}`
`723`	`723`
`724`	`724`	`/**`