fixed bug when trying to leak private variables while using "module.exports = ..."

jhnns · jhnns · commit 18ca74d9c514 · 2012-06-04T17:46:12.000+02:00
diff --git a/lib/getLeakingSrc.js b/lib/getLeakingSrc.js
@@ -4,13 +4,13 @@
  * Returns the source code that will leak private vars.
  *
  * e.g.:
- * "exports.__ = {myPrivateVar: myPrivateVar};"
+ * "module.exports.__ = {myPrivateVar: myPrivateVar};"
  *
  * @param {Array<String>} leaks
  * @return {String}
  */
 function getLeakingSrc(leaks) {
-    var src = "exports.__ = {",
+    var src = "module.exports.__ = {",
         varName,
         i;
 
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name" : "rewire",
-    "version" : "0.1.1",
+    "version" : "0.1.2",
     "description" : "Dependency injection for node.js applications",
     "keywords" : [
         "dependency",
diff --git a/test/getLeakingSrc.test.js b/test/getLeakingSrc.test.js
@@ -4,13 +4,13 @@ var expect = require("expect.js"),
     getLeakingWrapper = require("../lib/getLeakingSrc.js");
 
 describe("getLeakingWrapper", function () {
-    it("should return 'exports.__ = {};'", function () {
-        expect(getLeakingWrapper([])).to.be("exports.__ = {};");
+    it("should return 'module.exports.__ = {};'", function () {
+        expect(getLeakingWrapper([])).to.be("module.exports.__ = {};");
     });
-    it("should return 'exports.__ = {somethingPrivate:somethingPrivate,somethingSecret:somethingSecret};'", function () {
+    it("should return 'module.exports.__ = {somethingPrivate:somethingPrivate,somethingSecret:somethingSecret};'", function () {
         var leakArr = ["somethingPrivate", "somethingSecret"];
 
         expect(getLeakingWrapper(leakArr))
-            .to.be("exports.__ = {somethingPrivate:somethingPrivate,somethingSecret:somethingSecret};");
+            .to.be("module.exports.__ = {somethingPrivate:somethingPrivate,somethingSecret:somethingSecret};");
     });
 });
diff --git a/test/rewire.test.js b/test/rewire.test.js
@@ -70,18 +70,22 @@ describe("rewire", function () {
         rewired.exportAll();
         expect(rewired.console).to.be(456);
     });
-    it("should leak private variables", function () {
+    it("should leak private variables with both exports-styles (exports.bla = bla and module.exports = bla)", function () {
         var rewired,
             leaks = ["myPrivateVar"];
 
-        rewired = rewire("./testModules/A/moduleA.js", null, null, leaks);
+        rewired = rewire("./testModules/privateModules/privateModuleA.js", null, null, leaks);
+        expect(rewired.__.myPrivateVar).to.be("Hello I'm very private");
+        rewired = rewire("./testModules/privateModules/privateModuleB.js", null, null, leaks);
         expect(rewired.__.myPrivateVar).to.be("Hello I'm very private");
     });
-    it("should leak private functions", function () {
+    it("should leak private functions with both exports-styles (exports.bla = bla and module.exports = bla)", function () {
         var rewired,
             leaks = ["myPrivateFunction"];
 
-        rewired = rewire("./testModules/A/moduleA.js", null, null, leaks);
+        rewired = rewire("./testModules/privateModules/privateModuleA.js", null, null, leaks);
+        expect(rewired.__.myPrivateFunction()).to.be("Hello I'm very private");
+        rewired = rewire("./testModules/privateModules/privateModuleB.js", null, null, leaks);
         expect(rewired.__.myPrivateFunction()).to.be("Hello I'm very private");
     });
     it("should leak nothing on demand", function () {
diff --git a/test/testModules/A/moduleA.js b/test/testModules/A/moduleA.js
@@ -9,12 +9,6 @@ var path = require("path"),
     toSrc = require("toSrc"),   // node_modules path
     index = require("../");     // index.js path
 
-var myPrivateVar = "Hello I'm very private";
-
-function myPrivateFunction() {
-    return "Hello I'm very private";
-}
-
 function exportAll() {
     // expose all required modules to test for mocks
     exports.fs = fs;
diff --git a/test/testModules/privateModules/privateModuleA.js b/test/testModules/privateModules/privateModuleA.js
@@ -0,0 +1,10 @@
+"use strict"; // run code in ES5 strict mode
+
+var myPrivateVar = "Hello I'm very private";
+
+function myPrivateFunction() {
+    return "Hello I'm very private";
+}
+
+// privateModuleA and privateModuleB use different styles of exports
+exports.bla = "somevalue";
diff --git a/test/testModules/privateModules/privateModuleB.js b/test/testModules/privateModules/privateModuleB.js
@@ -0,0 +1,10 @@
+"use strict"; // run code in ES5 strict mode
+
+var myPrivateVar = "Hello I'm very private";
+
+function myPrivateFunction() {
+    return "Hello I'm very private";
+}
+
+// privateModuleA and privateModuleB use different styles of exports
+module.exports = function bla() {};

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name" : "rewire",`
`3`		`- "version" : "0.1.1",`
	`3`	`+ "version" : "0.1.2",`
`4`	`4`	`"description" : "Dependency injection for node.js applications",`
`5`	`5`	`"keywords" : [`
`6`	`6`	`"dependency",`