fix leak, add test, for jhnns#33

Trott · Trott · commit 5b237d99ef05 · 2014-10-28T11:56:55.000-07:00
diff --git a/lib/rewire.js b/lib/rewire.js
@@ -56,7 +56,7 @@ function internalRewire(parentModulePath, targetPath) {
 
     // Check if the module uses the strict mode.
     // If so we must ensure that "use strict"; stays at the beginning of the module.
-    src = fs.readFileSync(targetPath, "utf8");
+    var src = fs.readFileSync(targetPath, "utf8");
     if (detectStrictMode(src) === true) {
         prelude = ' "use strict"; ' + prelude;
     }
diff --git a/test/rewire.test.js b/test/rewire.test.js
@@ -31,4 +31,10 @@ describe("rewire", function () {
         });
         expect(coffeeModule.readFileSync()).to.be("It works!");
     });
+    it("should keep src variable in function scope", function () {
+        //expect(src).to.be(undefined);
+        // detectStrictMode();
+        // console.dir(global);
+        expect(global.src).to.be(undefined);
+    });
 });

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ function internalRewire(parentModulePath, targetPath) {`
`56`	`56`
`57`	`57`	`// Check if the module uses the strict mode.`
`58`	`58`	`// If so we must ensure that "use strict"; stays at the beginning of the module.`
`59`		`- src = fs.readFileSync(targetPath, "utf8");`
	`59`	`+ var src = fs.readFileSync(targetPath, "utf8");`
`60`	`60`	`if (detectStrictMode(src) === true) {`
`61`	`61`	`prelude = ' "use strict"; ' + prelude;`
`62`	`62`	`}`