STYLE: Update python scripts to fix RUF059 unpacked variable never used

jamesobutler · jcfr · jcfr · commit 04cb90d27e5b · 2025-09-12T14:17:26.000+02:00
See https://docs.astral.sh/ruff/rules/unused-unpacked-variable/ Adding the prefix underscore allows the variables to still be defined for easy use in the future to be able to use the variable and understand what is unpacked at that position. Changes applied by temporarily updating the `ruff` version to `v0.13.0` and specifying `--unsafe-fixes` in the `.pre-commit-config.yaml`. Remaining errors were manually reviewed and fixed Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
diff --git a/Applications/SlicerApp/Testing/Python/DWMRIMultishellIOTests.py b/Applications/SlicerApp/Testing/Python/DWMRIMultishellIOTests.py
@@ -151,7 +151,7 @@ def test_nrrd_dwi_roundtrip(test_nrrd_path):
     storagenode1.SetFileName(tmp_nrrd1)
     storagenode1.WriteData(dw_node1)
 
-    parsed_nrrd2, dw_node2 = test_nrrd_dwi_load(test_nrrd_path, tmp_nrrd1)
+    _parsed_nrrd2, dw_node2 = test_nrrd_dwi_load(test_nrrd_path, tmp_nrrd1)
 
     # re-save NRRD again
     storagenode2 = slicer.vtkMRMLNRRDStorageNode()
@@ -161,7 +161,7 @@ def test_nrrd_dwi_roundtrip(test_nrrd_path):
     storagenode2.WriteData(dw_node2)
 
     # test twice-saved file against original NRRD
-    parsed_nrrd3, dw_node3 = test_nrrd_dwi_load(test_nrrd_path, tmp_nrrd2)
+    _parsed_nrrd3, _dw_node3 = test_nrrd_dwi_load(test_nrrd_path, tmp_nrrd2)
 
 
 def run_tests(data_dir, tmp_dir):
diff --git a/Applications/SlicerApp/Testing/Python/MeasureStartupTimes.py b/Applications/SlicerApp/Testing/Python/MeasureStartupTimes.py
@@ -130,15 +130,15 @@ def collect_modules(output_file):
   output.write(json.dumps(modules, indent=4))
 """.format(output_file))
 
-    (returnCode, stdout, stderr) = runSlicerAndExit(slicer_executable, ["--python-script", python_script.name])
+    (returnCode, _stdout, _stderr) = runSlicerAndExit(slicer_executable, ["--python-script", python_script.name])
     assert returnCode == EXIT_SUCCESS
     print("=> ok\n")
 
     return read_modules(output_file)
 
 
 def slicerRevision():
-    (returnCode, stdout, stderr) = runSlicerAndExit(slicer_executable, [
+    (returnCode, stdout, _stderr) = runSlicerAndExit(slicer_executable, [
         "--no-main-window", "--ignore-slicerrc", "--disable-modules",
         "--python-code", "print(slicer.app.repositoryRevision)",
     ])
diff --git a/Applications/SlicerApp/Testing/Python/ScriptedModuleCleanupTest.py b/Applications/SlicerApp/Testing/Python/ScriptedModuleCleanupTest.py
@@ -73,7 +73,7 @@ def check_exit_code(slicer_executable, testing_enabled=True, debug=False):
             args.append("--testing")
         else:
             args.append("--exit-after-startup")
-        (returnCode, stdout, stderr) = run(slicer_executable, args)
+        (returnCode, _stdout, _stderr) = run(slicer_executable, args)
 
         assert os.path.isfile(test_output_file)
 
diff --git a/Applications/SlicerApp/Testing/Python/SlicerDisplayNodeSequenceTest.py b/Applications/SlicerApp/Testing/Python/SlicerDisplayNodeSequenceTest.py
@@ -59,7 +59,7 @@ def test_ScalarVolumeDisplayNodeSequence(self):
         mrHead.GetDisplayNode().ApplyThresholdOn()
         mrHead.GetDisplayNode().SetAutoWindowLevel(False)
         mrHead.GetDisplayNode().SetWindowLevelMinMax(10, 120)
-        min, max = mrHead.GetImageData().GetScalarRange()
+        _min, max = mrHead.GetImageData().GetScalarRange()
         mrHead.GetDisplayNode().SetThreshold(0, max)
         window_preset = 99
         level_preset = 49
@@ -69,7 +69,7 @@ def test_ScalarVolumeDisplayNodeSequence(self):
         mrHead2 = sampleDataLogic.downloadMRHead()
         mrHead2.GetDisplayNode().SetAndObserveColorNodeID("vtkMRMLColorTableNodeRed")
         mrHead2.GetDisplayNode().ApplyThresholdOn()
-        min, max = mrHead2.GetImageData().GetScalarRange()
+        _min, max = mrHead2.GetImageData().GetScalarRange()
         mrHead2.GetDisplayNode().SetThreshold(79, max)
         mrHead2.GetDisplayNode().ApplyThresholdOn()
         mrHead2.GetDisplayNode().SetAutoWindowLevel(False)
diff --git a/Applications/SlicerApp/Testing/Python/SlicerOptionDisableSettingsTest.py b/Applications/SlicerApp/Testing/Python/SlicerOptionDisableSettingsTest.py
@@ -81,7 +81,7 @@ def checkKeepTemporarySettingsWithoutDisableSettingsDisplayWarning(slicer_execut
     args = list(common_args)
     args.remove("--disable-settings")
     args.extend(["--keep-temporary-settings"])
-    (returnCode, stdout, stderr) = runSlicerAndExit(slicer_executable, args)
+    (returnCode, _stdout, stderr) = runSlicerAndExit(slicer_executable, args)
     expectedMessage = "Argument '--keep-temporary-settings' requires '--settings-disabled' to be specified."
     if expectedMessage not in stderr:
         print(f"=> return code{returnCode}\n")
diff --git a/Applications/SlicerApp/Testing/Python/SlicerTransformInteractionTest1.py b/Applications/SlicerApp/Testing/Python/SlicerTransformInteractionTest1.py
@@ -96,7 +96,7 @@ def test_3D_interactionDefaults(self):
 
         # self.delayDisplay("Starting test_3D_interactionDefaults")
         logic = SlicerTransformInteractionTest1Logic()
-        tNode, tdNode = logic.addTransform()
+        _tNode, tdNode = logic.addTransform()
         self.assertFalse(tdNode.GetEditorVisibility())
         self.assertFalse(tdNode.GetEditorSliceIntersectionVisibility())
 
@@ -423,7 +423,7 @@ def test_3D_parentTransform(self):
         markupNode.AddControlPoint([-1500.0, -200.0, -100.0])
 
         logic = SlicerTransformInteractionTest1Logic()
-        parentNode, parendDisplayNode = logic.addTransform()
+        parentNode, _parendDisplayNode = logic.addTransform()
 
         leafNode, tdNode = logic.addTransform()
         slicer.app.layoutManager().layout = slicer.vtkMRMLLayoutNode.SlicerLayoutOneUp3DView
diff --git a/Base/Python/slicer/tests/test_slicer_util_VTKObservationMixin.py b/Base/Python/slicer/tests/test_slicer_util_VTKObservationMixin.py
@@ -117,7 +117,7 @@ def test_getObserver(self):
         priority = 42.0
 
         foo.addObserver(obj, event, callback, group=group, priority=priority)
-        group_, tag_, priority_ = foo.getObserver(obj, event, callback)
+        group_, _tag, priority_ = foo.getObserver(obj, event, callback)
 
         self.assertEqual(group, group_)
         self.assertEqual(priority, priority_)
diff --git a/Base/Python/slicer/util.py b/Base/Python/slicer/util.py
@@ -2895,7 +2895,7 @@ def removeObservers(self, method=None):
             for obj, events in self.__observations.items():
                 for e, methods in events.items():
                     if method in methods:
-                        g, t, p = methods.pop(method)
+                        _g, t, _p = methods.pop(method)
                         obj.RemoveObserver(t)
 
     def addObserver(self, obj, event, method, group="none", priority=0.0):
@@ -2917,7 +2917,7 @@ def removeObserver(self, obj, event, method):
         try:
             events = self.__observations[obj]
             methods = events[event]
-            group, tag, priority = methods.pop(method)
+            _group, tag, _priority = methods.pop(method)
             obj.RemoveObserver(tag)
         except KeyError:
             warn("does not have observer")
@@ -3580,7 +3580,7 @@ def extractArchive(archiveFilePath, outputDir, expectedNumberOfExtractedFiles=No
     if not os.path.exists(archiveFilePath):
         logging.error("Specified file %s does not exist" % (archiveFilePath))
         return False
-    fileName, fileExtension = os.path.splitext(archiveFilePath)
+    _fileName, fileExtension = os.path.splitext(archiveFilePath)
     if fileExtension.lower() != ".zip":
         # TODO: Support other archive types
         logging.error("Only zip archives are supported now, got " + fileExtension)
diff --git a/Modules/Loadable/Markups/Testing/Python/MarkupsCurveCoordinateFrameTest.py b/Modules/Loadable/Markups/Testing/Python/MarkupsCurveCoordinateFrameTest.py
@@ -65,7 +65,7 @@ def createCoordinateSystemsModel(curve, axisLength=5):
 
 
 def addCoordinateSystemUpdater(updateInfo):
-    model, curve, coordinateSystemAppender, curvePointToWorldTransform, transform, transformer = updateInfo
+    _model, curve, _coordinateSystemAppender, _curvePointToWorldTransform, _transform, _transformer = updateInfo
     observation = curve.AddObserver(slicer.vtkMRMLMarkupsNode.PointModifiedEvent,
                                     lambda caller, eventData, updateInfo=updateInfo: updateCoordinateSystemsModel(updateInfo))
     return [curve, observation]
diff --git a/Modules/Scripted/DICOMLib/DICOMBrowser.py b/Modules/Scripted/DICOMLib/DICOMBrowser.py
@@ -446,7 +446,7 @@ def examineForLoading(self):
         of what to load
         """
 
-        (self.loadablesByPlugin, loadEnabled) = self.getLoadablesFromFileLists(self.fileLists)
+        (self.loadablesByPlugin, _loadEnabled) = self.getLoadablesFromFileLists(self.fileLists)
         DICOMLib.selectHighestConfidenceLoadables(self.loadablesByPlugin)
         self.loadableTable.setLoadables(self.loadablesByPlugin)
         self.updateButtonStates()
diff --git a/Modules/Scripted/DICOMLib/DICOMProcesses.py b/Modules/Scripted/DICOMLib/DICOMProcesses.py
@@ -230,7 +230,7 @@ def killStoreSCPProcesses(self):
 
     def killStoreSCPProcessesPosix(self, uniqueListener):
         p = subprocess.Popen(["ps", "-A"], stdout=subprocess.PIPE)
-        out, err = p.communicate()
+        out, _err = p.communicate()
         for line in out.splitlines():
             line = line.decode()
             if self.STORESCP_PROCESS_FILE_NAME in line:
diff --git a/Modules/Scripted/DICOMPlugins/DICOMScalarVolumePlugin.py b/Modules/Scripted/DICOMPlugins/DICOMScalarVolumePlugin.py
@@ -352,7 +352,7 @@ def examineFiles(self, files):
         # then adjust confidence values based on warnings
         #
         for loadable in loadables:
-            loadable.files, distances, loadable.warning = DICOMUtils.getSortedImageFiles(loadable.files, self.spacingEpsilon)
+            loadable.files, _distances, loadable.warning = DICOMUtils.getSortedImageFiles(loadable.files, self.spacingEpsilon)
 
         loadablesBetterThanAllFiles = []
         if allFilesLoadable.warning != "":
@@ -909,7 +909,7 @@ def cornersToWorld(self, volumeNode, corners):
             This can be used to confirm that an acquisition transform has correctly
             mapped the slice corners to match the dicom acquisition.
             """
-            columns, rows, slices = volumeNode.GetImageData().GetDimensions()
+            _columns, _rows, slices = volumeNode.GetImageData().GetDimensions()
             worldCorners = numpy.zeros(shape=[slices, 2, 2, 3])
             for slice in range(slices):
                 for row in range(2):
diff --git a/Modules/Scripted/ScreenCapture/ScreenCapture.py b/Modules/Scripted/ScreenCapture/ScreenCapture.py
@@ -1134,7 +1134,7 @@ def captureImageFromView(self, view, filename=None, transparentBackground=False,
             writer.Write()
 
     def createImageWriter(self, filename):
-        name, extension = os.path.splitext(filename)
+        _name, extension = os.path.splitext(filename)
         if extension.lower() == ".png":
             return vtk.vtkPNGWriter()
         elif extension.lower() == ".jpg" or extension.lower() == ".jpeg":
@@ -1143,7 +1143,7 @@ def createImageWriter(self, filename):
             raise ValueError(_("Unsupported image format based on file name {filename}").format(filename=filename))
 
     def createImageReader(self, filename):
-        name, extension = os.path.splitext(filename)
+        _name, extension = os.path.splitext(filename)
         if extension.lower() == ".png":
             return vtk.vtkPNGReader()
         elif extension.lower() == ".jpg" or extension.lower() == ".jpeg":
diff --git a/Modules/Scripted/WebServer/WebServer.py b/Modules/Scripted/WebServer/WebServer.py
@@ -518,7 +518,7 @@ def onWritable(self, fileno):
     def onServerSocketNotify(self, fileno):
         self.logMessage("got request on %d" % fileno)
         try:
-            (connectionSocket, clientAddress) = self.socket.accept()
+            (connectionSocket, _clientAddress) = self.socket.accept()
             fileno = connectionSocket.fileno()
             self.requestCommunicators[fileno] = self.SlicerRequestCommunicator(connectionSocket, self.requestHandlers, self.docroot, self.logMessage, self.enableCORS)
             self.logMessage("Connected on %s fileno %d" % (connectionSocket, connectionSocket.fileno()))
diff --git a/Utilities/Scripts/SEMToMediaWiki.py b/Utilities/Scripts/SEMToMediaWiki.py
@@ -303,7 +303,7 @@ def SEMToMediaWikiProg():
     )
     parser.epilog = program_description
     #    print program_description
-    (options, args) = parser.parse_args()
+    (options, _args) = parser.parse_args()
 
     #    It may be desirable in the future to automatically push information to the
     #    WIKI page without having to copy and paste.
diff --git a/Utilities/Scripts/qrcc.py b/Utilities/Scripts/qrcc.py
@@ -53,7 +53,7 @@ def compileResources(in_path, out_file, args):
 
     # Run rcc
     proc = subprocess.Popen(command, stdout=subprocess.PIPE, stderr=sys.stderr)
-    data, err = proc.communicate()
+    data, _err = proc.communicate()
 
     # Check that rcc ran successfully
     if proc.returncode != 0:
