Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 7d20e9b

Browse files
committed
use ternary op instead of max from omitted lib
1 parent fdc70ab commit 7d20e9b

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

tiny_obj_loader.h

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1789,9 +1789,9 @@ bool LoadObj(attrib_t *attrib, std::vector<shape_t> *shapes,
17891789
unsigned int current_smoothing_id =
17901790
0; // Initial value. 0 means no smoothing.
17911791

1792-
int greatest_vertex_index = -1;
1793-
int greatest_normal_index = -1;
1794-
int greatest_texcoord_index = -1;
1792+
int greatest_v_idx = -1;
1793+
int greatest_vn_idx = -1;
1794+
int greatest_vt_idx = -1;
17951795

17961796
shape_t shape;
17971797

@@ -1911,9 +1911,9 @@ bool LoadObj(attrib_t *attrib, std::vector<shape_t> *shapes,
19111911
return false;
19121912
}
19131913

1914-
greatest_vertex_index = std::max(greatest_vertex_index, vi.v_idx);
1915-
greatest_normal_index = std::max(greatest_normal_index, vi.vn_idx);
1916-
greatest_texcoord_index = std::max(greatest_texcoord_index, vi.vt_idx);
1914+
greatest_v_idx = greatest_v_idx > vi.v_idx ? greatest_v_idx : vi.v_idx;
1915+
greatest_vn_idx = greatest_vn_idx > vi.vn_idx ? greatest_vn_idx : vi.vn_idx;
1916+
greatest_vt_idx = greatest_vt_idx > vi.vt_idx ? greatest_vt_idx : vi.vt_idx;
19171917

19181918
face.vertex_indices.push_back(vi);
19191919
size_t n = strspn(token, " \t\r");
@@ -2161,9 +2161,9 @@ bool LoadObj(attrib_t *attrib, std::vector<shape_t> *shapes,
21612161
// Ignore unknown command.
21622162
}
21632163

2164-
if (greatest_vertex_index * 3 >= int(v.size())
2165-
|| greatest_normal_index * 3 >= int(vn.size())
2166-
|| greatest_texcoord_index * 2 >= int(vt.size()))
2164+
if (greatest_v_idx * 3 >= int(v.size())
2165+
|| greatest_vn_idx * 3 >= int(vn.size())
2166+
|| greatest_vt_idx * 2 >= int(vt.size()))
21672167
{
21682168
if (err) {
21692169
std::stringstream ss;

0 commit comments

Comments
 (0)