From 0d2018b2cd19b5a3a509c3c2f98d351f86e8a148 Mon Sep 17 00:00:00 2001
From: Salar Ali Mumtaz <salar@stackadapt.com>
Date: Tue, 8 Jun 2021 16:25:02 -0400
Subject: [PATCH 1/2] Disable SendReqHistogram metric

---
 rpc/client.go | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/rpc/client.go b/rpc/client.go
index c39c665621..c9ef27d697 100644
--- a/rpc/client.go
+++ b/rpc/client.go
@@ -16,7 +16,6 @@ package rpc
 import (
 	"context"
 	"io"
-	"strconv"
 	"sync"
 	"sync/atomic"
 	"time"
@@ -524,12 +523,12 @@ func sendBatchRequest(
 
 // SendRequest sends a Request to server and receives Response.
 func (c *rpcClient) SendRequest(ctx context.Context, addr string, req *Request, timeout time.Duration) (*Response, error) {
-	start := time.Now()
-	reqType := req.Type.String()
-	storeID := strconv.FormatUint(req.Context.GetPeer().GetStoreId(), 10)
-	defer func() {
-		metrics.SendReqHistogram.WithLabelValues(reqType, storeID).Observe(time.Since(start).Seconds())
-	}()
+	// start := time.Now()
+	// reqType := req.Type.String()
+	// storeID := strconv.FormatUint(req.Context.GetPeer().GetStoreId(), 10)
+	// defer func() {
+	// 	metrics.SendReqHistogram.WithLabelValues(reqType, storeID).Observe(time.Since(start).Seconds())
+	// }()
 
 	connArray, err := c.getConnArray(addr)
 	if err != nil {

From bf67fdc64da3556ed70e53c3c1bf55b17662c7d3 Mon Sep 17 00:00:00 2001
From: Salar Ali Mumtaz <salar@stackadapt.com>
Date: Tue, 8 Jun 2021 16:36:16 -0400
Subject: [PATCH 2/2] Remove spammy logs

---
 locate/region_cache.go | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/locate/region_cache.go b/locate/region_cache.go
index aee89bb6f7..a5b2a9af6d 100644
--- a/locate/region_cache.go
+++ b/locate/region_cache.go
@@ -471,16 +471,16 @@ func (c *RegionCache) DropStoreOnSendRequestFail(ctx *RPCContext, err error) {
 	c.mu.Unlock()
 
 	// Store's meta may be out of date.
-	var failedStoreAddr string
+	// var failedStoreAddr string
 	c.storeMu.Lock()
-	store, ok := c.storeMu.stores[failedStoreID]
+	_, ok = c.storeMu.stores[failedStoreID]
 	if ok {
-		failedStoreAddr = store.Addr
+		// failedStoreAddr = store.Addr
 		delete(c.storeMu.stores, failedStoreID)
 	}
 	c.storeMu.Unlock()
-	log.Infof("drop regions that on the store %d(%s) due to send request fail, err: %v",
-		failedStoreID, failedStoreAddr, err)
+	// log.Infof("drop regions that on the store %d(%s) due to send request fail, err: %v",
+	// 	failedStoreID, failedStoreAddr, err)
 }
 
 // OnRegionStale removes the old region and inserts new regions into the cache.