Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Overhaul SMODS.destroy_cards() #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
english5040 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Overhaul SMODS.destroy_cards() #1038

english5040 wants to merge 1 commit into from

Conversation

@english5040
Copy link
Collaborator

@english5040 english5040 commented Oct 25, 2025 •
edited
Loading

  • Returns destroyed cards in .destroyed
  • uses a table for arguments
  • skip_destroy_animation is refactored out
  • rename skip_anim arg. to pinch_anim, this makes more sense as we are using a specific animation
  • args.delay inserts a delay between destroy animation and calc. Vanilla Hanged Man uses 0.3. In the general case, this makes the result look a lot better
  • args.no_run allows the user to use the logic of this function however they want (see Immolate for use case)

Additional Info:

  • I didn't modify api's or I've made a PR to the wiki repo.
  • I didn't modify api's or I've updated lsp definitions.
  • I didn't make new lovely files or all new lovely files have appropriate priority.

@english5040 english5040 marked this pull request as draft October 28, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GauntletGames-2086 GauntletGames-2086 Awaiting requested review from GauntletGames-2086 GauntletGames-2086 is a code owner

@Aurelius7309 Aurelius7309 Awaiting requested review from Aurelius7309 Aurelius7309 is a code owner

@Eremel Eremel Awaiting requested review from Eremel Eremel is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@english5040