Allow setting cache-dir to False to omit the arg

kaste · kaste · commit 869d9bb04ccc · 2020-03-21T20:06:34.000+01:00
The user can set `cache-dir` to `False` to omit the arg from the command
completely. This is especially useful if the actual cache dir is configured
in the `mypy.ini` file.

Omit automatically in case the default location `.mypy_cache` exists.
Likely it is populated and the right thing.

In all cases do not manually edit `cmd`. Just set the setting and let
SublimeLinter do the rest.
diff --git a/linter.py b/linter.py
@@ -92,10 +92,9 @@ def cmd(self):
         else:
             cmd.append('${temp_file}')
 
-        # Add a temporary cache dir to the command if none was specified.
-        # Helps keep the environment clean
-        # by not littering everything with `.mypy_cache` folders.
-        if not self.settings.get('cache-dir'):
+        # Compare against `''` so the user can set just `False`,
+        # for example if the cache is configured in "mypy.ini".
+        if self.settings.get('cache-dir') == '':
             cwd = self.get_working_dir()
             if not cwd:  # abort silently
                 self.notify_unassign()
