🌴 based on PR comments

alexcjohnson · alexcjohnson · commit cdcd6200907d · 2018-05-11T17:14:57.000-04:00
diff --git a/src/lib/index.js b/src/lib/index.js
@@ -507,18 +507,14 @@ lib.tagSelected = function(calcTrace, trace, ptNumber2cdIndex) {
         }
     }
 
-    function isPtIndexValid(v) {
-        return isNumeric(v) && v >= 0 && v % 1 === 0;
-    }
-
     function isCdIndexValid(v) {
         return v !== undefined && v < calcTrace.length;
     }
 
     for(var i = 0; i < selectedpoints.length; i++) {
         var ptIndex = selectedpoints[i];
 
-        if(isPtIndexValid(ptIndex)) {
+        if(lib.isIndex(ptIndex)) {
             var ptNumber = ptIndex2ptNumber ? ptIndex2ptNumber[ptIndex] : ptIndex;
             var cdIndex = ptNumber2cdIndex ? ptNumber2cdIndex[ptNumber] : ptNumber;
 
diff --git a/src/traces/sankey/calc.js b/src/traces/sankey/calc.js
@@ -14,8 +14,8 @@ var wrap = require('../../lib/gup').wrap;
 
 function circularityPresent(nodeList, sources, targets) {
 
-    var nodes = nodeList.map(function() { return []; });
-    var nodeLen = nodes.length;
+    var nodeLen = nodeList.length;
+    var nodes = Lib.init2dArray(nodeLen, 0);
 
     for(var i = 0; i < Math.min(sources.length, targets.length); i++) {
         if(Lib.isIndex(sources[i], nodeLen) && Lib.isIndex(targets[i], nodeLen)) {

Original file line number	Diff line number	Diff line change
`@@ -507,18 +507,14 @@ lib.tagSelected = function(calcTrace, trace, ptNumber2cdIndex) {`
`507`	`507`	`}`
`508`	`508`	`}`
`509`	`509`
`510`		`- function isPtIndexValid(v) {`
`511`		`- return isNumeric(v) && v >= 0 && v % 1 === 0;`
`512`		`- }`
`513`		`-`
`514`	`510`	`function isCdIndexValid(v) {`
`515`	`511`	`return v !== undefined && v < calcTrace.length;`
`516`	`512`	`}`
`517`	`513`
`518`	`514`	`for(var i = 0; i < selectedpoints.length; i++) {`
`519`	`515`	`var ptIndex = selectedpoints[i];`
`520`	`516`
`521`		`- if(isPtIndexValid(ptIndex)) {`
	`517`	`+ if(lib.isIndex(ptIndex)) {`
`522`	`518`	`var ptNumber = ptIndex2ptNumber ? ptIndex2ptNumber[ptIndex] : ptIndex;`
`523`	`519`	`var cdIndex = ptNumber2cdIndex ? ptNumber2cdIndex[ptNumber] : ptNumber;`
`524`	`520`