From c3b4a01d6d54bb99db9e5bae9def2931f887cb1d Mon Sep 17 00:00:00 2001 From: sadick254 Date: Thu, 19 Aug 2021 19:16:54 +0300 Subject: [PATCH 1/6] Remote module defaults to false enableRemoteModule now defaults to false and is in the verge of being deprecated. https://www.electronjs.org/docs/breaking-changes#default-changed-enableremotemodule-defaults-to-false --- lib/worker-manager.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/worker-manager.js b/lib/worker-manager.js index 409a1085e6..17b9588191 100644 --- a/lib/worker-manager.js +++ b/lib/worker-manager.js @@ -268,7 +268,7 @@ export class RendererProcess { this.onExecStarted = onExecStarted; this.win = new BrowserWindow({show: !!process.env.ATOM_GITHUB_SHOW_RENDERER_WINDOW, - webPreferences: {nodeIntegration: true}}); + webPreferences: {nodeIntegration: true, enableRemoteModule: true}}); this.webContents = this.win.webContents; // this.webContents.openDevTools(); From 9207c7b2a793327ae26b71f50fde4e63c50e9c5f Mon Sep 17 00:00:00 2001 From: sadick254 Date: Thu, 19 Aug 2021 21:12:25 +0300 Subject: [PATCH 2/6] Remove windows-build installation step --- .github/workflows/ci.yml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0f3e43b3a1..df3afbc826 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -24,11 +24,6 @@ jobs: with: channel: ${{ matrix.channel }} - - name: install windows build tools - if: contains(matrix.os, 'windows') - run: | - choco install visualcpp-build-tools --version=14.0.25420.1 --ignore-dependencies -y --params "'/IncludeRequired'" - echo "VCTargetsPath='C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\v140'" >> $GITHUB_ENV - name: install dependencies run: apm ci From 2053290edf225d02789913dadfcec0995685ba28 Mon Sep 17 00:00:00 2001 From: sadick254 Date: Thu, 19 Aug 2021 21:50:49 +0300 Subject: [PATCH 3/6] Prepare v0.36.10 release --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index 016cdd9da5..cafe6d2056 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "github", - "version": "0.36.9", + "version": "0.36.10", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index eaf4acf285..c008cf5d55 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "github", "main": "./lib/index", - "version": "0.36.9", + "version": "0.36.10", "description": "GitHub integration", "repository": "https://github.com/atom/github", "license": "MIT", From 1d6057d6745470ceb7ca9bcc9a83eaec00da8942 Mon Sep 17 00:00:00 2001 From: steven nguyen Date: Mon, 25 Oct 2021 14:41:09 -0500 Subject: [PATCH 4/6] Don't use deprecated `Buffer` According to https://nodejs.org/en/docs/guides/buffer-constructor-deprecation/, `Buffer(number)` should be replaced by `Buffer.alloc(number)` --- test/git-strategies.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/git-strategies.test.js b/test/git-strategies.test.js index c39b8dca60..3d7ad41b85 100644 --- a/test/git-strategies.test.js +++ b/test/git-strategies.test.js @@ -837,7 +837,7 @@ import * as reporterProxy from '../lib/reporter-proxy'; it('returns an empty diff', async function() { const workingDirPath = await cloneRepository('three-files'); const git = createTestStrategy(workingDirPath); - const data = new Buffer(10); + const data = Buffer.alloc(10); for (let i = 0; i < 10; i++) { data.writeUInt8(i + 200, i); } From f867d24b9a1feca7cc9190e696ff3608f68f07a5 Mon Sep 17 00:00:00 2001 From: DeeDeeG Date: Sun, 17 Apr 2022 19:08:00 -0400 Subject: [PATCH 5/6] CI: Use 'windows-2019' image for Windows tests 'windows-latest' is currently 'windows-2022' with Visual Studio 2022. Old versions of node-gyp don't know how to find Visual Studio 2022, so the package build fails. Switch back to 'windows-2019' with Visual Studio 2019, which is supported by node-gyp 5.x, which apm still uses. --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index df3afbc826..7d30ce8063 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,7 +9,7 @@ jobs: name: tests strategy: matrix: - os: [ubuntu-18.04, macos-latest, windows-latest] + os: [ubuntu-18.04, macos-latest, windows-2019] channel: [beta, nightly] fail-fast: false runs-on: ${{ matrix.os }} From 5e72f801c134c713658773a90452f4bfb87c990f Mon Sep 17 00:00:00 2001 From: Musa Ibrahim Date: Wed, 28 Sep 2022 11:52:01 +0100 Subject: [PATCH 6/6] add sunset message --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index e43d03aff3..d7d7d2b5ce 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,5 @@ -# Atom GitHub Package +##### Atom and all repositories under Atom will be archived on December 15, 2022. Learn more in our [official announcement](https://github.blog/2022-06-08-sunsetting-atom/) + # Atom GitHub Package | Build | Code Coverage | |-------|---------------|