Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 40b8c4b

Browse files
jakubtobiaszjakubtobiasz
authored
minor #15031 [Behat] Minor fixes in scenarios and contexts (coldic3)
This PR was merged into the 1.12 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.12 | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Related tickets | follow up to #14940 | | License | MIT | Commits ------- [Behat] Minor fixes in ShippingContext [Behat] Minor fix in a scenario
2 parents 9ab7a66 + 8da576c commit 40b8c4b

2 files changed

Lines changed: 20 additions & 20 deletions

File tree

‎features/cart/shopping_cart/resolving_default_shipping_method_in_cart_summary_based_on_method_position.feature‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
Feature: Viewing a cart summary with the correct default shipping method
33
In order to see details about my order
44
As a Visitor
5-
I want see my cart summary with the correct shipping method based on its position
5+
I want to see my cart summary with the correct shipping method based on its position
66

77
Background:
88
Given the store operates on a single channel in "United States"

‎src/Sylius/Behat/Context/Setup/ShippingContext.php‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -109,15 +109,15 @@ public function theStoreShipsEverywhereForFreeForAllChannels(array $channels): v
109109
/**
110110
* @Given the store (also )allows shipping with :name
111111
*/
112-
public function theStoreAllowsShippingMethodWithName($name): void
112+
public function theStoreAllowsShippingMethodWithName(string $name): void
113113
{
114114
$this->saveShippingMethod($this->shippingMethodExampleFactory->create(['name' => $name, 'enabled' => true]));
115115
}
116116

117117
/**
118118
* @Given the store (also )allows shipping with :name identified by :code
119119
*/
120-
public function theStoreAllowsShippingMethodWithNameAndCode($name, $code): void
120+
public function theStoreAllowsShippingMethodWithNameAndCode(string $name, string $code): void
121121
{
122122
$this->saveShippingMethod($this->shippingMethodExampleFactory->create([
123123
'name' => $name,
@@ -130,23 +130,23 @@ public function theStoreAllowsShippingMethodWithNameAndCode($name, $code): void
130130
/**
131131
* @Given the store (also )allows shipping with :name at position :position
132132
*/
133-
public function theStoreAllowsShippingMethodWithNameAndPosition($name, $position): void
133+
public function theStoreAllowsShippingMethodWithNameAndPosition(string $name, int $position): void
134134
{
135135
$shippingMethod = $this->shippingMethodExampleFactory->create([
136136
'name' => $name,
137137
'enabled' => true,
138138
'zone' => $this->getShippingZone(),
139139
]);
140140

141-
$shippingMethod->setPosition((int) $position);
141+
$shippingMethod->setPosition($position);
142142

143143
$this->saveShippingMethod($shippingMethod);
144144
}
145145

146146
/**
147147
* @Given /^the store(?:| also) allows shipping with "([^"]+)" at position (\d+) with ("[^"]+") fee$/
148148
*/
149-
public function theStoreAllowsShippingMethodWithNameAndPositionAndFee($name, $position, $fee): void
149+
public function theStoreAllowsShippingMethodWithNameAndPositionAndFee(string $name, int $position, int $fee): void
150150
{
151151
$channel = $this->sharedStorage->get('channel');
152152
$configuration = $this->getConfigurationByChannels([$channel], $fee);
@@ -162,7 +162,7 @@ public function theStoreAllowsShippingMethodWithNameAndPositionAndFee($name, $po
162162
'channels' => [$channel],
163163
]);
164164

165-
$shippingMethod->setPosition((int) $position);
165+
$shippingMethod->setPosition($position);
166166

167167
$this->saveShippingMethod($shippingMethod);
168168
}
@@ -201,7 +201,7 @@ public function theStoreAllowsShippingWithAnd(string ...$names): void
201201
* @Given /^the store has "([^"]+)" shipping method with ("[^"]+") fee within the ("[^"]+" zone)$/
202202
* @Given /^the store has "([^"]+)" shipping method with ("[^"]+") fee for the (rest of the world)$/
203203
*/
204-
public function storeHasShippingMethodWithFeeAndZone($shippingMethodName, $fee, ZoneInterface $zone): void
204+
public function storeHasShippingMethodWithFeeAndZone(string $shippingMethodName, int $fee, ZoneInterface $zone): void
205205
{
206206
$channel = $this->sharedStorage->get('channel');
207207
$configuration = $this->getConfigurationByChannels([$channel], $fee);
@@ -221,7 +221,7 @@ public function storeHasShippingMethodWithFeeAndZone($shippingMethodName, $fee,
221221
/**
222222
* @Given /^the store has "([^"]+)" shipping method with ("[^"]+") fee$/
223223
*/
224-
public function storeHasShippingMethodWithFee($shippingMethodName, $fee): void
224+
public function storeHasShippingMethodWithFee(string $shippingMethodName, int $fee): void
225225
{
226226
$channel = $this->sharedStorage->get('channel');
227227
$configuration = $this->getConfigurationByChannels([$channel], $fee);
@@ -242,10 +242,10 @@ public function storeHasShippingMethodWithFee($shippingMethodName, $fee): void
242242
* @Given /^the store has "([^"]+)" shipping method with ("[^"]+") fee per shipment for ("[^"]+" channel) and ("[^"]+") for ("[^"]+" channel)$/
243243
*/
244244
public function storeHasShippingMethodWithFeePerShipmentForChannels(
245-
$shippingMethodName,
246-
$firstFee,
245+
string $shippingMethodName,
246+
int $firstFee,
247247
ChannelInterface $firstChannel,
248-
$secondFee,
248+
int $secondFee,
249249
ChannelInterface $secondChannel,
250250
): void {
251251
$configuration = [];
@@ -269,7 +269,7 @@ public function storeHasShippingMethodWithFeePerShipmentForChannels(
269269
*/
270270
public function storeHasShippingMethodWithFeePerShipmentForChannel(
271271
string $shippingMethodName,
272-
string $fee,
272+
int $fee,
273273
ChannelInterface $channel,
274274
): void {
275275
$configuration = [$channel->getCode() => ['amount' => $fee]];
@@ -291,10 +291,10 @@ public function storeHasShippingMethodWithFeePerShipmentForChannel(
291291
* @Given /^the store has "([^"]+)" shipping method with ("[^"]+") fee per unit for ("[^"]+" channel) and ("[^"]+") for ("[^"]+" channel)$/
292292
*/
293293
public function storeHasShippingMethodWithFeePerUnitForChannels(
294-
$shippingMethodName,
295-
$firstFee,
294+
string $shippingMethodName,
295+
int $firstFee,
296296
ChannelInterface $firstChannel,
297-
$secondFee = null,
297+
int $secondFee = null,
298298
ChannelInterface $secondChannel = null,
299299
): void {
300300
$configuration = [];
@@ -323,7 +323,7 @@ public function storeHasShippingMethodWithFeePerUnitForChannels(
323323
/**
324324
* @Given /^the store has disabled "([^"]+)" shipping method with ("[^"]+") fee$/
325325
*/
326-
public function storeHasDisabledShippingMethodWithFee($shippingMethodName, $fee): void
326+
public function storeHasDisabledShippingMethodWithFee(string $shippingMethodName, int $fee): void
327327
{
328328
$channel = $this->sharedStorage->get('channel');
329329
$configuration = $this->getConfigurationByChannels([$channel], $fee);
@@ -343,7 +343,7 @@ public function storeHasDisabledShippingMethodWithFee($shippingMethodName, $fee)
343343
/**
344344
* @Given /^the store has an archival "([^"]+)" shipping method with ("[^"]+") fee$/
345345
*/
346-
public function theStoreHasArchivalShippingMethodWithFee($shippingMethodName, $fee): void
346+
public function theStoreHasArchivalShippingMethodWithFee(string $shippingMethodName, int $fee): void
347347
{
348348
$channel = $this->sharedStorage->get('channel');
349349
$configuration = $this->getConfigurationByChannels([$channel], $fee);
@@ -364,7 +364,7 @@ public function theStoreHasArchivalShippingMethodWithFee($shippingMethodName, $f
364364
/**
365365
* @Given /^the store has "([^"]+)" shipping method with ("[^"]+") fee per unit$/
366366
*/
367-
public function theStoreHasShippingMethodWithFeePerUnit($shippingMethodName, $fee): void
367+
public function theStoreHasShippingMethodWithFeePerUnit(string $shippingMethodName, int $fee): void
368368
{
369369
$channel = $this->sharedStorage->get('channel');
370370
$configuration = $this->getConfigurationByChannels([$channel], $fee);
@@ -384,7 +384,7 @@ public function theStoreHasShippingMethodWithFeePerUnit($shippingMethodName, $fe
384384
/**
385385
* @Given /^the store has "([^"]+)" shipping method with ("[^"]+") fee not assigned to any channel$/
386386
*/
387-
public function storeHasShippingMethodWithFeeNotAssignedToAnyChannel($shippingMethodName, $fee): void
387+
public function storeHasShippingMethodWithFeeNotAssignedToAnyChannel(string $shippingMethodName, int $fee): void
388388
{
389389
$channel = $this->sharedStorage->get('channel');
390390
$configuration = $this->getConfigurationByChannels([$channel], $fee);

0 commit comments

Comments
 (0)