[ProductAttributeValue] Fix removing attribute values from product

GSadee · GSadee · commit b23149d9aae2 · 2017-01-16T23:36:59.000+01:00
diff --git a/features/product/managing_products/adding_product_with_text_attribute.feature b/features/product/managing_products/adding_product_with_text_attribute.feature
@@ -36,7 +36,7 @@ Feature: Adding a new product with text attribute
         And attribute "Gun caliber" of product "44 Magnum" should be "11 mm"
         And attribute "Overall length" of product "44 Magnum" should be "30.5 cm"
 
-    @ui @javascript @todo
+    @ui @javascript
     Scenario: Adding and removing text attributes on product create page
         Given I want to create a new simple product
         When I specify its code as "44_MAGNUM"
diff --git a/features/product/managing_products/adding_text_attributes_to_existing_product.feature b/features/product/managing_products/adding_text_attributes_to_existing_product.feature
@@ -28,7 +28,7 @@ Feature: Adding attributes to an existing product
         And attribute "Gun caliber" of product "44 Magnum" should be "11 mm"
         And attribute "Overall length" of product "44 Magnum" should be "30.5 cm"
 
-    @ui @javascript @todo
+    @ui @javascript
     Scenario: Adding and removing text attributes on product update page
         When I want to modify the "44 Magnum" product
         And I set its "Overall length" attribute to "30.5 cm" in "English (United States)"
@@ -37,7 +37,7 @@ Feature: Adding attributes to an existing product
         Then I should be notified that it has been successfully edited
         And product "44 Magnum" should not have a "Overall length" attribute
 
-    @ui @javascript @todo
+    @ui @javascript
     Scenario: Adding and removing after saving text attributes on product update page
         Given this product has text attribute "Gun caliber" with value "11 mm" in "English (United States)" locale
         When I want to modify the "44 Magnum" product
diff --git a/src/Sylius/Bundle/UiBundle/Resources/private/js/sylius-product-attributes.js b/src/Sylius/Bundle/UiBundle/Resources/private/js/sylius-product-attributes.js
@@ -43,7 +43,7 @@
     }
 
     function modifyAttributesListOnSelectorElementDelete(removedValue) {
-        $('#attributesContainer > .attribute[data-id="'+removedValue+'"]').remove();
+        $('#attributesContainer .attribute[data-id="'+removedValue+'"]').remove();
     }
 
     function modifySelectorOnAttributesListElementDelete() {

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`function modifyAttributesListOnSelectorElementDelete(removedValue) {`
`46`		`- $('#attributesContainer > .attribute[data-id="'+removedValue+'"]').remove();`
	`46`	`+ $('#attributesContainer .attribute[data-id="'+removedValue+'"]').remove();`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`function modifySelectorOnAttributesListElementDelete() {`