refactor #13468 [CatalogPromotion] Rename actions and scopes (SirDomin)

GSadee · web-flow · commit b53855caa23c · 2022-01-11T14:07:10.000+01:00
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.11 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Renaming `sylius.catalog_promotion.actions` => `sylius.catalog_promotion.actions_types` `sylius.catalog_promotion.scopes` => `sylius.catalog_promotion.scopes_types`  Commits ------- fdafdaa [CatalogPromotion] Rename actions and scopes
diff --git a/src/Sylius/Bundle/CoreBundle/Resources/config/services/validators.xml b/src/Sylius/Bundle/CoreBundle/Resources/config/services/validators.xml
@@ -65,7 +65,7 @@
         </service>
 
         <service id="Sylius\Bundle\CoreBundle\Validator\Constraints\CatalogPromotionScopeValidator">
-            <argument>%sylius.catalog_promotion.scopes%</argument>
+            <argument>%sylius.catalog_promotion.scopes_types%</argument>
             <argument type="tagged_iterator" tag="sylius.catalog_promotion.scope_validator" index-by="key" />
             <tag name="validator.constraint_validator" alias="sylius_catalog_promotion_scope" />
         </service>
diff --git a/src/Sylius/Bundle/PromotionBundle/DependencyInjection/Compiler/SetCatalogPromotionActionTypesPass.php b/src/Sylius/Bundle/PromotionBundle/DependencyInjection/Compiler/SetCatalogPromotionActionTypesPass.php
@@ -31,6 +31,6 @@ public function process(ContainerBuilder $container): void
             }
         }
 
-        $container->setParameter('sylius.catalog_promotion.actions', $types);
+        $container->setParameter('sylius.catalog_promotion.actions_types', $types);
     }
 }
diff --git a/src/Sylius/Bundle/PromotionBundle/DependencyInjection/Compiler/SetCatalogPromotionScopeTypesPass.php b/src/Sylius/Bundle/PromotionBundle/DependencyInjection/Compiler/SetCatalogPromotionScopeTypesPass.php
@@ -31,6 +31,6 @@ public function process(ContainerBuilder $container): void
             }
         }
 
-        $container->setParameter('sylius.catalog_promotion.scopes', $types);
+        $container->setParameter('sylius.catalog_promotion.scopes_types', $types);
     }
 }
diff --git a/src/Sylius/Bundle/PromotionBundle/Resources/config/services/validators.xml b/src/Sylius/Bundle/PromotionBundle/Resources/config/services/validators.xml
@@ -34,7 +34,7 @@
         </service>
 
         <service id="Sylius\Bundle\PromotionBundle\Validator\CatalogPromotionActionValidator">
-            <argument>%sylius.catalog_promotion.actions%</argument>
+            <argument>%sylius.catalog_promotion.actions_types%</argument>
             <argument type="tagged_iterator" tag="sylius.catalog_promotion.action_validator" index-by="key" />
             <tag name="validator.constraint_validator" alias="sylius_catalog_promotion_action" />
         </service>
diff --git a/src/Sylius/Bundle/PromotionBundle/Tests/DependencyInjection/Compiler/SetCatalogPromotionActionTypesPassTest.php b/src/Sylius/Bundle/PromotionBundle/Tests/DependencyInjection/Compiler/SetCatalogPromotionActionTypesPassTest.php
@@ -38,7 +38,7 @@ public function it_sets_action_types_parameter(): void
         $this->compile();
 
         $this->assertContainerBuilderHasParameter(
-            'sylius.catalog_promotion.actions',
+            'sylius.catalog_promotion.actions_types',
             ['custom', 'another_custom', 'second_custom']
         );
     }
diff --git a/src/Sylius/Bundle/PromotionBundle/Tests/DependencyInjection/Compiler/SetCatalogPromotionScopeTypesPassTest.php b/src/Sylius/Bundle/PromotionBundle/Tests/DependencyInjection/Compiler/SetCatalogPromotionScopeTypesPassTest.php
@@ -38,7 +38,7 @@ public function it_sets_scope_types_parameter(): void
         $this->compile();
 
         $this->assertContainerBuilderHasParameter(
-            'sylius.catalog_promotion.scopes',
+            'sylius.catalog_promotion.scopes_types',
             ['custom', 'another_custom', 'second_custom']
         );
     }

Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,6 @@ public function process(ContainerBuilder $container): void`
`31`	`31`	`}`
`32`	`32`	`}`
`33`	`33`
`34`		`- $container->setParameter('sylius.catalog_promotion.actions', $types);`
	`34`	`+ $container->setParameter('sylius.catalog_promotion.actions_types', $types);`
`35`	`35`	`}`
`36`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ public function it_sets_action_types_parameter(): void`
`38`	`38`	`$this->compile();`
`39`	`39`
`40`	`40`	`$this->assertContainerBuilderHasParameter(`
`41`		`- 'sylius.catalog_promotion.actions',`
	`41`	`+ 'sylius.catalog_promotion.actions_types',`
`42`	`42`	`['custom', 'another_custom', 'second_custom']`
`43`	`43`	`);`
`44`	`44`	`}`