bug #12823 [API] Allow creation of commands with no arguments with a default value (GSadee)

Zales0123 · web-flow · commit bf23a705293d · 2021-07-21T14:51:15.000+02:00
This PR was merged into the 1.9 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.9 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | fixes #12811 | License | MIT Fixes tests on 1.10 and master branches, where we test [RegisterShopUser](https://github.com/Sylius/Sylius/blob/1.10/src/Sylius/Bundle/ApiBundle/Command/RegisterShopUser.php#L69) that has new not nullable argument with a default value. Failing test: https://github.com/Sylius/Sylius/runs/3122767036?check_suite_focus=true#step:18:75 Commits ------- 80836cf [API] Allow creation of commands with no arguments with a default value
diff --git a/src/Sylius/Bundle/ApiBundle/Serializer/CommandDenormalizer.php b/src/Sylius/Bundle/ApiBundle/Serializer/CommandDenormalizer.php
@@ -41,7 +41,7 @@ public function denormalize($data, $type, $format = null, array $context = [])
 
         $missingFields = [];
         foreach ($parameters as $parameter) {
-            if (!isset($data[$parameter->getName()]) && !$parameter->allowsNull()) {
+            if (!isset($data[$parameter->getName()]) && !($parameter->allowsNull() || $parameter->isDefaultValueAvailable())) {
                 $missingFields[] = $parameter->getName();
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public function denormalize($data, $type, $format = null, array $context = [])`
`41`	`41`
`42`	`42`	`$missingFields = [];`
`43`	`43`	`foreach ($parameters as $parameter) {`
`44`		`- if (!isset($data[$parameter->getName()]) && !$parameter->allowsNull()) {`
	`44`	`+ if (!isset($data[$parameter->getName()]) && !($parameter->allowsNull() \|\| $parameter->isDefaultValueAvailable())) {`
`45`	`45`	`$missingFields[] = $parameter->getName();`
`46`	`46`	`}`
`47`	`47`	`}`