behat hostname fix

SirDomin · SirDomin · commit c2312c4aaaf3 · 2021-04-27T14:29:30.000+02:00
diff --git a/features/product/viewing_products/viewing_products_from_specific_taxon_and_channel.feature b/features/product/viewing_products/viewing_products_from_specific_taxon_and_channel.feature
@@ -5,8 +5,8 @@ Feature: Viewing products from a specific taxon and a channel
     I want to be able to view products from a specific taxon and a channel
 
     Background:
-        Given the store operates on a channel named "Poland"
-        And the store operates on another channel named "United States"
+        Given the store operates on a channel named "Poland" with hostname "poland"
+        And the store operates on another channel named "United States" with hostname "united-states"
         And the store classifies its products as "T-Shirts" and "Funny"
         And the store has a product "T-Shirt Banana" available in "Poland" channel
         And this product belongs to "T-Shirts"
diff --git a/src/Sylius/Behat/Context/Api/Shop/ProductContext.php b/src/Sylius/Behat/Context/Api/Shop/ProductContext.php
@@ -54,7 +54,7 @@ public function __construct(
     /**
      * @Given I am browsing channel :channel
      */
-    public function iAmBrowsingChannel(ChannelInterface $channel)
+    public function iAmBrowsingChannel(ChannelInterface $channel): void
     {
         $this->sharedStorage->set('hostname', $channel->getHostname());
     }
diff --git a/src/Sylius/Behat/Context/Setup/ChannelContext.php b/src/Sylius/Behat/Context/Setup/ChannelContext.php
@@ -111,14 +111,14 @@ public function storeOperatesOnASingleChannel($currencyCode = null)
      * @Given /^the store(?:| also) operates on (?:a|another) channel named "([^"]+)"$/
      * @Given /^the store(?:| also) operates on (?:a|another) channel named "([^"]+)" in "([^"]+)" currency$/
      * @Given the store operates on a channel identified by :code code
-     * @Given the store (also) operates on a channel named :channelName with hostname :hostname
+     * @Given the store (also) operates on a(nother) channel named :channelName with hostname :hostname
      */
     public function theStoreOperatesOnAChannelNamed(string $channelName, string $currencyCode = null, string $hostname = null): void
     {
         $channelCode = StringInflector::nameToLowercaseCode($channelName);
         $defaultData = $this->defaultChannelFactory->create($channelCode, $channelName, $currencyCode);
 
-        $defaultData['channel']->setHostname(strtolower($hostname ?: str_replace(' ', '-', $channelName)));
+        $defaultData['channel']->setHostname($hostname);
 
         $this->sharedStorage->setClipboard($defaultData);
         $this->sharedStorage->set('channel', $defaultData['channel']);

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public function __construct(`
`54`	`54`	`/**`
`55`	`55`	`* @Given I am browsing channel :channel`
`56`	`56`	`*/`
`57`		`- public function iAmBrowsingChannel(ChannelInterface $channel)`
	`57`	`+ public function iAmBrowsingChannel(ChannelInterface $channel): void`
`58`	`58`	`{`
`59`	`59`	`$this->sharedStorage->set('hostname', $channel->getHostname());`
`60`	`60`	`}`