bug #10854 [Behat][Admin][Order] Fix scenarios for displaying promotions on master after upmerge (GSadee)

pamil · web-flow · commit cc6d36286415 · 2019-11-14T10:42:10.000+01:00
This PR was merged into the 1.6-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | after #10846, associated with #10853 | License | MIT Commits ------- a14a599 [Behat][Admin][Order] Fix scenarios for displaying promotions on master after upmerge
diff --git a/features/order/managing_orders/seeing_order_discounts.feature b/features/order/managing_orders/seeing_order_discounts.feature
@@ -33,5 +33,6 @@ Feature: Seeing discounts of an order
         And the customer chose "Free" shipping method to "United States" with "Cash on Delivery" payment
         When I view the summary of the order "#00000666"
         Then the order's items total should be "$29.00"
-        And the order's promotion total should be "$0.00"
+        And the order's promotion total should be "-$10.00"
+        And the order's promotion discount should be "-$10.00" from "Holiday promotion" promotion
         And the order's total should be "$29.00"
diff --git a/src/Sylius/Behat/Page/Admin/Order/ShowPage.php b/src/Sylius/Behat/Page/Admin/Order/ShowPage.php
@@ -188,19 +188,9 @@ public function hasShippingCharge(string $shippingCharge): bool
 
     public function getOrderPromotionTotal(): string
     {
-        /** @var NodeElement[] $rows */
-        $rows = $this->getElement('table')->findAll('css', 'tbody tr');
+        $promotionTotalElement = $this->getElement('promotion_total');
 
-        $orderPromotionTotal = 0;
-
-        foreach ($rows as $row) {
-            $unitOrderPromotion = $row->find('css', 'td:nth-child(4)')->getText();
-            $quantity = $row->find('css', 'td:nth-child(6)')->getText();
-            $itemOrderPromotion = (float) trim(str_replace('-$', '', $unitOrderPromotion)) * $quantity;
-            $orderPromotionTotal += (int) ($itemOrderPromotion * 100);
-        }
-
-        return $this->getFormattedMoney($orderPromotionTotal > 0 ? -1 * $orderPromotionTotal : $orderPromotionTotal);
+        return trim(str_replace('Promotion total:', '', $promotionTotalElement->getText()));
     }
 
     public function hasPromotionDiscount(string $promotionName, string $promotionAmount): bool
