Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit e560527

Browse files
stloydstloyd
committed
Bugfix | Don't declare default_bus for Messenger & always use Sylius Bus
1 parent 69044b7 commit e560527

7 files changed

Lines changed: 27 additions & 17 deletions

File tree

‎.github/workflows/application.yml‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -86,17 +86,17 @@ jobs:
8686

8787
-
8888
name: Validate Doctrine mapping
89-
run: bin/console doctrine:schema:validate --skip-sync -vvv
89+
run: bin/console doctrine:schema:validate --skip-sync -vvv --env=test
9090
if: always() && steps.end-of-setup.outcome == 'success'
9191

9292
-
9393
name: Validate Twig templates
94-
run: bin/console lint:twig src
94+
run: bin/console lint:twig src --env=test
9595
if: always() && steps.end-of-setup.outcome == 'success'
9696

9797
-
9898
name: Validate Yaml files
99-
run: bin/console lint:yaml src
99+
run: bin/console lint:yaml src --env=test
100100
if: always() && steps.end-of-setup.outcome == 'success'
101101

102102
-
@@ -186,7 +186,7 @@ jobs:
186186
187187
-
188188
name: Warmup cache
189-
run: bin/console cache:warmup
189+
run: bin/console cache:warmup --env=test
190190

191191
-
192192
name: Make filesystem readonly
@@ -195,23 +195,23 @@ jobs:
195195
-
196196
name: Prepare application database
197197
run: |
198-
APP_DEBUG=1 bin/console doctrine:database:create -vvv
199-
bin/console doctrine:migrations:migrate -n -vvv
198+
APP_DEBUG=1 bin/console doctrine:database:create -vvv --env=test
199+
bin/console doctrine:migrations:migrate -n -vvv --env=test
200200
201201
-
202202
name: Test provided migrations
203203
run: |
204-
bin/console doctrine:migrations:migrate first --no-interaction
205-
bin/console doctrine:migrations:migrate latest --no-interaction
206-
bin/console doctrine:schema:validate --skip-mapping -vvv
204+
bin/console doctrine:migrations:migrate first --no-interaction --env=test
205+
bin/console doctrine:migrations:migrate latest --no-interaction --env=test
206+
bin/console doctrine:schema:validate --skip-mapping -vvv --env=test
207207
208208
-
209209
name: Test installer
210-
run: bin/console sylius:install --no-interaction -vvv
210+
run: bin/console sylius:install --no-interaction -vvv --env=test
211211

212212
-
213213
name: Load fixtures
214-
run: bin/console sylius:fixtures:load default --no-interaction
214+
run: bin/console sylius:fixtures:load default --no-interaction --env=test
215215

216216
-
217217
name: Run PHPSpec
@@ -351,7 +351,7 @@ jobs:
351351
352352
-
353353
name: Warmup cache
354-
run: bin/console cache:warmup
354+
run: bin/console cache:warmup --env=test
355355

356356
-
357357
name: Run webserver
@@ -360,13 +360,13 @@ jobs:
360360
-
361361
name: Prepare application database
362362
run: |
363-
APP_DEBUG=1 bin/console doctrine:database:create -vvv
364-
bin/console doctrine:migrations:migrate -n -vvv
363+
APP_DEBUG=1 bin/console doctrine:database:create -vvv --env=test
364+
bin/console doctrine:migrations:migrate -n -vvv --env=test
365365
366366
-
367367
name: Build assets
368368
run: |
369-
bin/console assets:install public -vvv
369+
bin/console assets:install public -vvv --env=test
370370
yarn build
371371
372372
-

‎config/packages/staging/messenger.yaml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
framework:
2+
messenger:
3+
default_bus: sylius_default.bus

‎config/packages/test/messenger.yaml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
framework:
2+
messenger:
3+
default_bus: sylius_default.bus

‎config/packages/test_cached/messenger.yaml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
framework:
2+
messenger:
3+
default_bus: sylius_default.bus

‎src/Sylius/Bundle/ApiBundle/Resources/config/services/command_handlers.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@
128128

129129
<service id="Sylius\Bundle\ApiBundle\CommandHandler\RequestResetPasswordTokenHandler">
130130
<argument type="service" id="sylius.repository.shop_user" />
131-
<argument type="service" id="messenger.default_bus" />
131+
<argument type="service" id="sylius_default.bus" />
132132
<argument type="service" id="sylius.shop_user.token_generator.password_reset" />
133133
<tag name="messenger.message_handler" bus="sylius_default.bus" />
134134
</service>

‎src/Sylius/Bundle/ApiBundle/test/config/config.yaml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ framework:
2626
serializer:
2727
mapping:
2828
paths: ['%kernel.project_dir%/config/serialization']
29+
messenger:
30+
default_bus: sylius_default.bus
2931

3032
doctrine_migrations:
3133
storage:

‎src/Sylius/Bundle/CoreBundle/Resources/config/app/messenger.yaml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,5 @@ framework:
1313
# Route your messages to the transports
1414
# 'App\Message\YourMessage': async
1515

16-
default_bus: sylius_default.bus
1716
buses:
1817
sylius_default.bus: ~

0 commit comments

Comments
 (0)