qa fixes to feature

arti0090 · arti0090 · commit ea0c326f64c1 · 2020-11-13T07:23:09.000+01:00
diff --git a/src/Sylius/Behat/Context/Api/Shop/PromotionContext.php b/src/Sylius/Behat/Context/Api/Shop/PromotionContext.php
@@ -57,7 +57,7 @@ public function iShouldBeNotifiedThatCouponIsInvalid(): void
     {
         $response = $this->cartsClient->getLastResponse();
 
-        Assert::same($response->getStatusCode(), 500);
+        Assert::same($response->getStatusCode(), 400);
         Assert::notNull($this->responseChecker->getError($response));
     }
 
diff --git a/src/Sylius/Bundle/ApiBundle/CommandHandler/Cart/ApplyCouponToCartHandler.php b/src/Sylius/Bundle/ApiBundle/CommandHandler/Cart/ApplyCouponToCartHandler.php
@@ -44,7 +44,7 @@ public function __construct(
         $this->orderProcessor = $orderProcessor;
     }
 
-    public function __invoke(ApplyCouponToCart $command): void
+    public function __invoke(ApplyCouponToCart $command): OrderInterface
     {
         /** @var OrderInterface $cart */
         $cart = $this->orderRepository->findCartByTokenValue($command->getOrderTokenValue());
@@ -59,5 +59,7 @@ public function __invoke(ApplyCouponToCart $command): void
         $cart->setPromotionCoupon($promotionCoupon);
 
         $this->orderProcessor->process($cart);
+
+        return $cart;
     }
 }
diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/validation/ApplyCouponToCart.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/validation/ApplyCouponToCart.xml
@@ -13,7 +13,11 @@
 
 <constraint-mapping xmlns="http://symfony.com/schema/dic/constraint-mapping" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://symfony.com/schema/dic/constraint-mapping http://symfony.com/schema/dic/services/constraint-mapping-1.0.xsd">
     <class name="Sylius\Bundle\ApiBundle\Command\Cart\ApplyCouponToCart">
-        <constraint name="Sylius\Bundle\ApiBundle\Validator\Constraints\PromotionCouponEligibility" />
+        <constraint name="Sylius\Bundle\ApiBundle\Validator\Constraints\PromotionCouponEligibility">
+            <option name="groups">
+                <value>sylius</value>
+            </option>
+        </constraint>
         <property name="couponCode">
             <constraint name="NotNull" >
                 <option name="message">sylius.promotion_coupon.code.not_blank</option>

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ public function iShouldBeNotifiedThatCouponIsInvalid(): void`
`57`	`57`	`{`
`58`	`58`	`$response = $this->cartsClient->getLastResponse();`
`59`	`59`
`60`		`- Assert::same($response->getStatusCode(), 500);`
	`60`	`+ Assert::same($response->getStatusCode(), 400);`
`61`	`61`	`Assert::notNull($this->responseChecker->getError($response));`
`62`	`62`	`}`
`63`	`63`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ public function __construct(`
`44`	`44`	`$this->orderProcessor = $orderProcessor;`
`45`	`45`	`}`
`46`	`46`
`47`		`- public function __invoke(ApplyCouponToCart $command): void`
	`47`	`+ public function __invoke(ApplyCouponToCart $command): OrderInterface`
`48`	`48`	`{`
`49`	`49`	`/** @var OrderInterface $cart */`
`50`	`50`	`$cart = $this->orderRepository->findCartByTokenValue($command->getOrderTokenValue());`
`@@ -59,5 +59,7 @@ public function __invoke(ApplyCouponToCart $command): void`
`59`	`59`	`$cart->setPromotionCoupon($promotionCoupon);`
`60`	`60`
`61`	`61`	`$this->orderProcessor->process($cart);`
	`62`	`+`
	`63`	`+ return $cart;`
`62`	`64`	`}`
`63`	`65`	`}`