Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit ec752f3

Browse files
committed
Fixes after PR review
1 parent 0be231a commit ec752f3

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

UPGRADE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
### Attribute / AttributeBundle
1414

15-
* `AttributeValue::$localeCode` property was added to make it translatable. Now, every attribute value has a locale code to be properly displaying in different locales. All attribute values are migrated to new concept with migration `Version20170109143010`. Look at [this PR](https://github.com/Sylius/Sylius/pull/7219) if you have any problems with upgrade.
15+
* `AttributeValue::$localeCode` property was added to make it translatable. Now, every attribute value has a locale code to be displayed properly in different locales. All attribute values are migrated to the new concept with migration `Version20170109143010`. Look at [this PR](https://github.com/Sylius/Sylius/pull/7219) if you have any problems with upgrade.
1616

1717
### Channel / ChannelBundle
1818

features/product/viewing_products/viewing_product_attributes.feature

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ Feature: Viewing product's attributes
1717
@ui
1818
Scenario: Viewing a detailed page with product's textarea attribute
1919
Given the store has a product "T-shirt banana"
20-
And this product has textarea attribute "T-shirt details" with value "Banana is very good material."
20+
And this product has textarea attribute "T-shirt details" with value "Banana is a very good material."
2121
When I check this product's details
22-
Then I should see the product attribute "T-shirt details" with value "Banana is very good material."
22+
Then I should see the product attribute "T-shirt details" with value "Banana is a very good material."
2323

2424
@ui
2525
Scenario: Viewing a detailed page with product's checkbox attribute

features/product/viewing_products/viewing_product_attributes_in_different_locales.feature

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ Feature: Viewing product's attributes in different locales
1111
And the store has a product "T-shirt banana"
1212
And this product has text attribute "T-shirt material" with value "Banana skin" in "English (United States)" locale
1313
And this product has text attribute "T-shirt material" with value "Skórka banana" in "Polish (Poland)" locale
14-
And this product has textarea attribute "T-shirt details" with value "Banana is very good material." in "English (United States)" locale
14+
And this product has textarea attribute "T-shirt details" with value "Banana is a very good material." in "English (United States)" locale
1515

1616
@ui
1717
Scenario: Viewing a detailed page with product's text attribute after local change
1818
When I switch to the "Polish (Poland)" locale
1919
When I view product "T-shirt banana"
2020
Then I should see the product attribute "T-shirt material" with value "Skórka banana"
21-
Then I should also see the product attribute "T-shirt details" with value "Banana is very good material."
21+
Then I should also see the product attribute "T-shirt details" with value "Banana is a very good material."

0 commit comments

Comments
 (0)