Provide failing test scenario for duplicated locales

pamil · pamil · commit ffa464ea772f · 2019-06-20T18:39:45.000+08:00
diff --git a/src/Sylius/Bundle/CoreBundle/Tests/Fixture/LocaleFixtureTest.php b/src/Sylius/Bundle/CoreBundle/Tests/Fixture/LocaleFixtureTest.php
@@ -36,7 +36,7 @@ public function locales_are_not_required(): void
      */
     public function locales_can_be_set(): void
     {
-        $this->assertConfigurationIsValid([['locales' => ['en_US' => true, 'pl_PL' => false, 'es_ES' => true]]], 'locales');
+        $this->assertConfigurationIsValid([['locales' => ['en_US', 'pl_PL', 'es_ES']]], 'locales');
     }
 
     /**
diff --git a/src/Sylius/Bundle/CoreBundle/spec/Fixture/LocaleFixtureSpec.php b/src/Sylius/Bundle/CoreBundle/spec/Fixture/LocaleFixtureSpec.php
@@ -0,0 +1,72 @@
+<?php
+
+namespace spec\Sylius\Bundle\CoreBundle\Fixture;
+
+use Doctrine\Common\Persistence\ObjectManager;
+use Sylius\Bundle\CoreBundle\Fixture\LocaleFixture;
+use PhpSpec\ObjectBehavior;
+use Prophecy\Argument;
+use Sylius\Bundle\FixturesBundle\Fixture\FixtureInterface;
+use Sylius\Component\Locale\Model\Locale;
+use Sylius\Component\Locale\Model\LocaleInterface;
+use Sylius\Component\Resource\Factory\FactoryInterface;
+
+class LocaleFixtureSpec extends ObjectBehavior
+{
+    function let(FactoryInterface $localeFactory, ObjectManager $localeManager): void
+    {
+        $this->beConstructedWith($localeFactory, $localeManager, 'default_LOCALE');
+    }
+
+    function it_is_a_fixture(): void
+    {
+        $this->shouldImplement(FixtureInterface::class);
+    }
+
+    function it_creates_and_persists_default_locale(FactoryInterface $localeFactory, ObjectManager $localeManager): void
+    {
+        $localeFactory->createNew()->willReturn(new Locale());
+
+        $localeManager->persist(Argument::that(function (LocaleInterface $locale): bool {
+            return $locale->getCode() === 'default_LOCALE';
+        }))->shouldBeCalledOnce();
+
+        $localeManager->flush()->shouldBeCalled();
+
+        $this->load(['locales' => []]);
+    }
+
+    function it_creates_and_persists_default_locale_and_other_specified_locales(FactoryInterface $localeFactory, ObjectManager $localeManager): void
+    {
+        $localeFactory->createNew()->willReturn(new Locale(), new Locale());
+
+        $localeManager->persist(Argument::that(function (LocaleInterface $locale): bool {
+            return $locale->getCode() === 'default_LOCALE';
+        }))->shouldBeCalledOnce();
+
+        $localeManager->persist(Argument::that(function (LocaleInterface $locale): bool {
+            return $locale->getCode() === 'pl_PL';
+        }))->shouldBeCalledOnce();
+
+        $localeManager->flush()->shouldBeCalled();
+
+        $this->load(['locales' => ['pl_PL']]);
+    }
+
+    function it_deduplicates_passed_locales_and_the_default_one(FactoryInterface $localeFactory, ObjectManager $localeManager): void
+    {
+        $localeFactory->createNew()->willReturn(new Locale(), new Locale(), new Locale(), new Locale());
+
+        $localeManager->persist(Argument::that(function (LocaleInterface $locale): bool {
+            return $locale->getCode() === 'default_LOCALE';
+        }))->shouldBeCalledOnce();
+
+        $localeManager->persist(Argument::that(function (LocaleInterface $locale): bool {
+            return $locale->getCode() === 'pl_PL';
+        }))->shouldBeCalledOnce();
+
+        $localeManager->flush()->shouldBeCalled();
+
+        $this->load(['locales' => ['pl_PL', 'default_LOCALE', 'pl_PL']]);
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ public function locales_are_not_required(): void`
`36`	`36`	`*/`
`37`	`37`	`public function locales_can_be_set(): void`
`38`	`38`	`{`
`39`		`- $this->assertConfigurationIsValid([['locales' => ['en_US' => true, 'pl_PL' => false, 'es_ES' => true]]], 'locales');`
	`39`	`+ $this->assertConfigurationIsValid([['locales' => ['en_US', 'pl_PL', 'es_ES']]], 'locales');`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`/**`