Thanks to visit codestin.com
Credit goes to github.com

Make possible to autowire services generated by ResourceBundle#10062

Merged

pamil merged 3 commits into

Sylius:masterfrom

pamil:1.4-autowiring-for-resource-bundle

Jan 9, 2019

Contributor

pamil commented Jan 2, 2019 •

edited

Loading

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Related tickets	-
License	MIT

This feature is only available when used with Symfony DependencyInjection ^4.2.

TODO:

Automatic tests
Symfony 4.2-based job on Travis

pamil added Feature RFC labels

pamil requested a review from a team as a code owner

January 2, 2019 15:29

pamil mentioned this pull request

Do not require clearing cache when changing ResourceBundle drivers or metadata classes #10063

Merged

pamil added a commit that referenced this pull request


          bug #10063 Do not require clearing cache when changing ResourceBundle…

c3ab417

… drivers or metadata classes (pamil)

This PR was merged into the 1.2 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.2
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | -
| License         | MIT

Makes working on PRs like #10062 easier.


Commits
-------

cddb6bf Do not require clearing cache when changing ResourceBundle drivers or metadata classes

pamil changed the title ~~[WIP] Make possible to autowire services generated by ResourceBundle~~ Make possible to autowire services generated by ResourceBundle

pamil force-pushed the 1.4-autowiring-for-resource-bundle branch 2 times, most recently from cfe966a to 1769995 Compare

January 5, 2019 12:50

CoderMaggie added the Roadmap label

Zales0123 added a commit to Zales0123/Sylius that referenced this pull request


          Fix test in ResourceBundle (taken from Sylius#10062)

b80fa00

pamil added a commit that referenced this pull request


          bug #10077 Fix select attributes according to recent Symfony form cha…

edddb99

…nges (Zales0123)

This PR was merged into the 1.2 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.2
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | related to symfony/symfony#29307
| License         | MIT

Due to the latest Symfony 4.1.10/3.4.21 release and changes introduced in linked PR, a bug in select attribute type araised 🌤 Apparently, possible to select values in attribute configuration was saved with `TextType` form type, even though `SelectAttributeValueTranslationsType` should be used. It was somehow parsed before, but know it's not possible and this PR fixes this absurdity 🖖 

Commits
-------

51f7ec2 Fix select attributes according to recent Symfony form changes
b80fa00 Fix test in ResourceBundle (taken from #10062)

pamil added a commit that referenced this pull request


          Merge branch '1.2' into 1.3

93d9535

* 1.2:
  Fix test in ResourceBundle (taken from #10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit that referenced this pull request


          Merge branch '1.3'

cae7b0a

* 1.3:
  Fix test in ResourceBundle (taken from #10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added 3 commits

January 8, 2019 15:57


          Make possible to autowire services generated by ResourceBundle

6a6122b


          Add automated tests for autowiring in ResourceBundle

edcdb4c


          Fix build on master with Symfony 4.2

b156a83

pamil force-pushed the 1.4-autowiring-for-resource-bundle branch from aa8f7b2 to b156a83 Compare

January 8, 2019 14:58

pamil closed this

pamil reopened this

lchrusciel approved these changes

View reviewed changes

Zales0123 approved these changes

View reviewed changes

pamil merged commit e4dd6c7 into Sylius:master

pamil deleted the 1.4-autowiring-for-resource-bundle branch

January 9, 2019 09:23

loic425 mentioned this pull request

[Behat] autowiring contexts monofony/SymfonyStarter#105

Merged

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.2' into 1.3

e442788

* 1.2:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.3'

9e13470

* 1.3:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.2' into 1.3

1d07f43

* 1.2:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.3'

f1df945

* 1.3:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.2' into 1.3

54789af

* 1.2:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.3'

97025fa

* 1.3:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.2' into 1.3

a2bdbaa

* 1.2:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.3'

6828e37

* 1.3:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.2' into 1.3

d862c4e

* 1.2:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.3'

f9611ff

* 1.3:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.2' into 1.3

ad5952d

* 1.2:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.3'

8556e64

* 1.3:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.2' into 1.3

593e3b6

* 1.2:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.3'

c2958e0

* 1.3:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.2' into 1.3

* 1.2:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.3'

bb6a777

* 1.3:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.2' into 1.3

45099d8

* 1.2:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.3'

34d3eab

* 1.3:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.2' into 1.3

78b55be

* 1.2:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.3'

bbc9d27

* 1.3:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.2' into 1.3

5a84147

* 1.2:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.3'

3f27e7c

* 1.3:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil pushed a commit to pamil/Sylius that referenced this pull request


          Fix test in ResourceBundle (taken from Sylius#10062)

df2b679

pamil added a commit to pamil/Sylius that referenced this pull request


          bug Sylius#10077 Fix select attributes according to recent Symfony fo…

3990c70

…rm changes (Zales0123)

This PR was merged into the 1.2 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.2
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | related to symfony/symfony#29307
| License         | MIT

Due to the latest Symfony 4.1.10/3.4.21 release and changes introduced in linked PR, a bug in select attribute type araised 🌤 Apparently, possible to select values in attribute configuration was saved with `TextType` form type, even though `SelectAttributeValueTranslationsType` should be used. It was somehow parsed before, but know it's not possible and this PR fixes this absurdity 🖖 

Commits
-------

51f7ec2 Fix select attributes according to recent Symfony form changes
b80fa00 Fix test in ResourceBundle (taken from Sylius#10062)

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.2' into 1.3

17623ca

* 1.2:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.3'

* 1.3:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.2' into 1.3

a063ac6

* 1.2:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.3'

af2b1c9

* 1.3:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.2' into 1.3

5a0b94e

* 1.2:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.3'

67307a7

* 1.3:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.2' into 1.3

e1789a8

* 1.2:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.3'

4e1ca21

* 1.3:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.2' into 1.3

1a645af

* 1.2:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.3'

6d88db2

* 1.3:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil added a commit to pamil/Sylius that referenced this pull request


          Merge branch '1.2' into 1.3

cb8ce02

* 1.2:
  Fix test in ResourceBundle (taken from Sylius#10062)
  Fix select attributes according to recent Symfony form changes
  It's 2019

pamil mentioned this pull request

[Documentation] Describe how to use autowiring Sylius/SyliusResourceBundle#96

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels