Using client from browser kit component instead of http kernel component#10426
Merged
Conversation
…ent. I am using the deprecated version because the Symfony\Component\BrowserKit\AbstractBrowser is first introduced in SF4.3. This commit fixed this issue when running behat tests: `Argument 1 passed to Sylius\Behat\Context\Api\Admin\ManagingTaxonsContext::__construct() must be an instance of Symfony\Component\HttpKernel\Client, instance of Symfony\Bundle\FrameworkBundle\KernelBrowser given`
lchrusciel
approved these changes
Jun 4, 2019
pamil
approved these changes
Jun 5, 2019
Contributor
|
Thank you, Joachim! 🎉 |
Contributor
Author
|
Thanks for the fast response! 🏎 💨 |
loevgaard
added a commit
to Setono/SyliusRedirectPlugin
that referenced
this pull request
Jun 5, 2019
Contributor
Author
|
For people finding this you can fix this temporarily by adding this to your # todo remove this when this PR is merged https://github.com/Sylius/Sylius/pull/10426
services:
test.client:
class: Symfony\Component\HttpKernel\Client
public: true
arguments:
- "@kernel"
- "%test.client.parameters%"
- "@test.client.history"
- "@test.client.cookiejar" |
loevgaard
added a commit
to Setono/SyliusMailchimpPlugin
that referenced
this pull request
Jun 5, 2019
Contributor
|
It's going to be fixed by symfony/symfony#31881. |
Contributor
Author
|
Then we probably shouldn't merge this PR anyways, should we? |
Contributor
|
There's no need AFAIK, we don't use any behaviour that was specific to HttpKernel's Client, so it's fine and backward compatible. |
Contributor
Author
|
Okay, cool :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using client from browser kit component instead of http kernel component. I am using the deprecated version because the Symfony\Component\BrowserKit\AbstractBrowser is first introduced in SF4.3 (not sure this is correct?).
This commit fixes this issue when running behat tests:
Argument 1 passed to Sylius\Behat\Context\Api\Admin\ManagingTaxonsContext::__construct() must be an instance of Symfony\Component\HttpKernel\Client, instance of Symfony\Bundle\FrameworkBundle\KernelBrowser given