Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Documentation] Delete additional lines to remove ShopBundle#10599

Merged
lchrusciel merged 1 commit into
Sylius:1.4from
wpje:patch-1
Aug 21, 2019
Merged

[Documentation] Delete additional lines to remove ShopBundle#10599
lchrusciel merged 1 commit into
Sylius:1.4from
wpje:patch-1

Conversation

@wpje
Copy link
Copy Markdown
Contributor

@wpje wpje commented Aug 20, 2019

These three lines have to be removed in order for Sylius to work without ShopBundle.

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@wpje wpje requested a review from a team as a code owner August 20, 2019 19:50
@CoderMaggie CoderMaggie added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Aug 21, 2019
Copy link
Copy Markdown
Contributor

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wpje, thanks a lot for the contribution and welcome to our community :)

These three lines have to be removed in order for Sylius to work without ShopBundle.
@lchrusciel lchrusciel changed the base branch from master to 1.4 August 21, 2019 07:28
@lchrusciel
Copy link
Copy Markdown
Contributor

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "patch-1" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@lchrusciel lchrusciel merged commit 066c0c2 into Sylius:1.4 Aug 21, 2019
@lchrusciel
Copy link
Copy Markdown
Contributor

Thank you, @wpje! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Documentation related issues and PRs - requests, fixes, proposals.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants