Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Product] Go to edit from product show page#10718

Merged
GSadee merged 4 commits into
Sylius:masterfrom
AdamKasp:go-to-edit-from-product-show-page
Oct 2, 2019
Merged

[Product] Go to edit from product show page#10718
GSadee merged 4 commits into
Sylius:masterfrom
AdamKasp:go-to-edit-from-product-show-page

Conversation

@AdamKasp
Copy link
Copy Markdown
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT

To improve UX I added edit button on the product show page and on each variant row.

Screenshot 2019-09-28 at 13 49 08

Screenshot 2019-09-28 at 13 49 18

@AdamKasp AdamKasp requested a review from a team as a code owner September 28, 2019 11:52
@AdamKasp AdamKasp changed the title [Product] Go to edit from product show page [WIP][Product] Go to edit from product show page Oct 1, 2019
@AdamKasp AdamKasp force-pushed the go-to-edit-from-product-show-page branch from e4aa2c5 to 32ee2f4 Compare October 1, 2019 08:22
@AdamKasp AdamKasp changed the title [WIP][Product] Go to edit from product show page [Product] Go to edit from product show page Oct 1, 2019
Comment thread src/Sylius/Behat/Context/Ui/Admin/MoveToEditPageFromProductShowPageContext.php Outdated
@GSadee GSadee added Admin AdminBundle related issues and PRs. UX Issues and PRs aimed at improving User eXperience. labels Oct 2, 2019
Comment thread src/Sylius/Behat/Context/Ui/Admin/MoveToEditPageFromProductShowPageContext.php Outdated
Comment thread src/Sylius/Behat/Page/Admin/Product/ShowPage.php Outdated
Comment thread src/Sylius/Behat/Resources/config/suites.yml Outdated
@AdamKasp AdamKasp force-pushed the go-to-edit-from-product-show-page branch 2 times, most recently from e710d68 to 8712f6f Compare October 2, 2019 11:55
@AdamKasp AdamKasp force-pushed the go-to-edit-from-product-show-page branch from 8712f6f to 297d1dc Compare October 2, 2019 12:00

namespace Sylius\Behat\Context\Ui\Admin;


Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary blank line

@GSadee GSadee merged commit f174e9b into Sylius:master Oct 2, 2019
@GSadee
Copy link
Copy Markdown
Member

GSadee commented Oct 2, 2019

Thank you, Adam! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin AdminBundle related issues and PRs. UX Issues and PRs aimed at improving User eXperience.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants