Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[API] Fixed OrderController save action issue in not html requests#11006

Merged
lchrusciel merged 1 commit into
Sylius:1.5from
pfazzi:issue_10930
Jan 13, 2020
Merged

[API] Fixed OrderController save action issue in not html requests#11006
lchrusciel merged 1 commit into
Sylius:1.5from
pfazzi:issue_10930

Conversation

@pfazzi
Copy link
Copy Markdown
Contributor

@pfazzi pfazzi commented Jan 9, 2020

Q A
Branch? 1.6
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #10930
License MIT

@pfazzi pfazzi requested a review from a team as a code owner January 9, 2020 16:01
@lchrusciel lchrusciel changed the base branch from master to 1.5 January 13, 2020 13:57
@lchrusciel
Copy link
Copy Markdown
Contributor

lchrusciel commented Jan 13, 2020

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "issue_10930" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@lchrusciel
Copy link
Copy Markdown
Contributor

lchrusciel commented Jan 13, 2020

Hello Patrick,

thank you very much for your contribution and welcome to our community!

As the problem exists from 1.5, so I have decided to rebase to the proper branch.

Have a great day ;)

lchrusciel
lchrusciel approved these changes Jan 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, I'm wondering why don't we have a test case for this issue... Patrick are you willing to take a look into our Api tests and try to write something?

@lchrusciel lchrusciel merged commit a7b2ae4 into Sylius:1.5 Jan 13, 2020
@lchrusciel
Copy link
Copy Markdown
Contributor

lchrusciel commented Jan 13, 2020

Thank you, Patrick! 🎉

@pfazzi
Copy link
Copy Markdown
Contributor Author

pfazzi commented Jan 14, 2020

Hello @lchrusciel, sorry for not being available but i have been very busy. If it's still needed I can have a look into sylius api test cases so that i can try to implement a proper test case for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lchrusciel lchrusciel lchrusciel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pfazzi @lchrusciel