Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Define countries for a channel#11055

Merged
lchrusciel merged 1 commit into
Sylius:masterfrom
pamil:countries-defined-for-channel
Jan 23, 2020
Merged

Define countries for a channel#11055
lchrusciel merged 1 commit into
Sylius:masterfrom
pamil:countries-defined-for-channel

Conversation

@pamil
Copy link
Copy Markdown
Contributor

@pamil pamil commented Jan 22, 2020

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets fixes #9122
License MIT

Currently used only in checkout addressing to limit the list of countries. If not defined, fallbacks to the previous behaviour - all enabled countries.

Screenshot 2020-01-22 at 20 10 51

@pamil pamil added the Feature New feature proposals. label Jan 22, 2020
@pamil pamil requested a review from a team as a code owner January 22, 2020 19:12
Comment thread src/Sylius/Bundle/AddressingBundle/Form/Type/CountryChoiceType.php Outdated
Comment thread src/Sylius/Bundle/AddressingBundle/Form/Type/CountryChoiceType.php Outdated
@pamil pamil force-pushed the countries-defined-for-channel branch from 1eaa58a to 2e68737 Compare January 23, 2020 09:03
return array_map(
/** @return string[] */
static function (NodeElement $element): string { return $element->getText(); },
$element->findAll('css', 'option[value!=""]')
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we cannot support data attributes here as well

@lchrusciel lchrusciel merged commit e8145f0 into Sylius:master Jan 23, 2020
@lchrusciel
Copy link
Copy Markdown
Contributor

Thank you, Kamil! 🥇

@pamil pamil deleted the countries-defined-for-channel branch January 23, 2020 12:23
pamil added a commit to Sylius/SyliusDemo that referenced this pull request Jan 23, 2020
billybrona pushed a commit to billybrona/SyliusDemo that referenced this pull request Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New feature proposals.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Countries available in the checkout made configurable per channel

4 participants