Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add notice about moved templates during upgrade#11357

Merged
pamil merged 1 commit into
Sylius:1.7from
jacquesbh:patch-1
Apr 16, 2020
Merged

Add notice about moved templates during upgrade#11357
pamil merged 1 commit into
Sylius:1.7from
jacquesbh:patch-1

Conversation

@jacquesbh
Copy link
Copy Markdown
Contributor

Using the old files leads to a not found template error in Front or Admin.

Q A
Branch? 1.7 or master, I don't know if we consider this as a bug fix or not :p
Bug fix? yes or no… for me yes, for others no.
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #X, partially #Y, mentioned in #Z
License MIT

This PR is quite simple. I've just added some information about the move of some templates.
I was using these templates and faced the issue in production since it was an edge case.
Better to tell than sorry.

@jacquesbh jacquesbh requested a review from a team as a code owner April 15, 2020 08:40
@lchrusciel
Copy link
Copy Markdown
Contributor

However, I'm not sure, if we didn't violate or BC Policy: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html#templates

/cc @pamil

@jacquesbh
Copy link
Copy Markdown
Contributor Author

I can add a We failed, we are really sorry, we renamed these files… if you want 🤣

😘

@pamil pamil added BC Break Potential Bug Potential bugs or bugfixes, that needs to be reproduced. and removed BC Break labels Apr 16, 2020
Copy link
Copy Markdown
Contributor

@pamil pamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good hotfix. However, we should fix the root cause - those templates shouldn't just disappear in 1.7.

Using the old files leads to a not found template error in Front or Admin.
@pamil pamil changed the base branch from master to 1.7 April 16, 2020 12:47
@pamil
Copy link
Copy Markdown
Contributor

pamil commented Apr 16, 2020

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "patch-1" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@pamil
Copy link
Copy Markdown
Contributor

pamil commented Apr 16, 2020

Created #11365 to track the core issue.

@pamil pamil merged commit 83ffbe0 into Sylius:1.7 Apr 16, 2020
@pamil
Copy link
Copy Markdown
Contributor

pamil commented Apr 16, 2020

Thank you, Jacques! 🎉

@jacquesbh jacquesbh deleted the patch-1 branch April 16, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Potential Bug Potential bugs or bugfixes, that needs to be reproduced.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants