Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Introduce limit parameter for quantity modifier#11370

Merged
Zales0123 merged 2 commits into
Sylius:masterfrom
arti0090:introduce-limit-modifier-parameter
Nov 13, 2020
Merged

Introduce limit parameter for quantity modifier#11370
Zales0123 merged 2 commits into
Sylius:masterfrom
arti0090:introduce-limit-modifier-parameter

Conversation

@arti0090
Copy link
Copy Markdown
Contributor

@arti0090 arti0090 commented Apr 17, 2020 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #10740
License MIT

@arti0090 arti0090 requested a review from a team as a code owner April 17, 2020 10:56
@Zales0123 Zales0123 added the DX Issues and PRs aimed at improving Developer eXperience. label Apr 17, 2020
@Zales0123 Zales0123 changed the base branch from master to 1.6 April 17, 2020 11:14
@Zales0123
Copy link
Copy Markdown
Contributor

Zales0123 commented Apr 17, 2020

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "introduce-limit-modifier-parameter" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@Zales0123 Zales0123 force-pushed the introduce-limit-modifier-parameter branch from 6fafa04 to c74f7c2 Compare April 17, 2020 11:14
Zales0123
Zales0123 approved these changes Apr 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could also mention this parameter somewhere over the rainbow in the documentation? For example in this section (we use an OrderItemQuantityModifier there)?

@probot-autolabeler probot-autolabeler Bot added the Maintenance CI configurations, READMEs, releases, etc. label Apr 30, 2020
@arti0090 arti0090 force-pushed the introduce-limit-modifier-parameter branch 2 times, most recently from d164c20 to 204ffc2 Compare April 30, 2020 09:54
@probot-autolabeler probot-autolabeler Bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Apr 30, 2020
lchrusciel
lchrusciel reviewed May 4, 2020
View reviewed changes
Comment thread docs/book/orders/orders.rst Outdated
@arti0090 arti0090 force-pushed the introduce-limit-modifier-parameter branch from e010320 to 63997bc Compare July 13, 2020 09:45
@arti0090 arti0090 changed the base branch from 1.6 to master July 13, 2020 09:45
@stale
Copy link
Copy Markdown

stale Bot commented Oct 12, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the Stale Issues and PRs with no recent activity, about to be closed soon. label Oct 12, 2020
@lchrusciel lchrusciel closed this Nov 12, 2020
@lchrusciel lchrusciel reopened this Nov 12, 2020
@stale stale Bot removed the Stale Issues and PRs with no recent activity, about to be closed soon. label Nov 12, 2020
@Zales0123 Zales0123 merged commit 578a02f into Sylius:master Nov 13, 2020
@Zales0123
Copy link
Copy Markdown
Contributor

Zales0123 commented Nov 13, 2020

Thanks, @arti0090! 🥇

@dependabot dependabot Bot mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Documentation Documentation related issues and PRs - requests, fixes, proposals. DX Issues and PRs aimed at improving Developer eXperience. Maintenance CI configurations, READMEs, releases, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rework the order item quantity limit into a parameter

3 participants

@arti0090 @Zales0123 @lchrusciel