Bug #9738 Fix nested form collections#11390
Conversation
lchrusciel
left a comment
There was a problem hiding this comment.
Hey Victorien,
thanks for your contribution! Your change seems to be ok. We need to fix master build before we will merge your PR.
Welcome to our community! :)
|
Hi Lukasz,
Thank you :) |
|
Btw. @vic-blt can you share some screenshots of the change done by this solution? Or an example code? |
|
Without the fix : With the fix : You can see that without the fix, |
If there are nested form collections, the value __name__ of the sub collection is being replaced by the parent collection index. Which makes every new sub collection items having the same index.
|
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
|
Thank you, Victorien! 🎉 |
If there are nested form collections, the value
__name__of the subcollection is being replaced by the parent collection index.
Which makes every new sub collection items having the same index.