Add title on most pages#11392
Merged
Merged
Conversation
lchrusciel
approved these changes
Apr 23, 2020
Contributor
|
thanks @dunglas, good point, but it would be even better to add the title of the current page before the channel name |
Contributor
Author
|
@kulczy I agree, but it can be done in other PRs right? |
Contributor
Author
|
@kulczy actually, I added a new commit! |
Contributor
|
great work! thank you |
kulczy
approved these changes
Apr 24, 2020
lchrusciel
approved these changes
Apr 24, 2020
Contributor
|
Thank you, Kévin! 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having "Sylius" displayed in the
<title>of every pages by default is weird and can be bad for SEO. I suggest to display the name of the current channel instead.